hold_stalling.hard typo

Bug #1488604 reported by Josh Stompro
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Confirmed
Undecided
Unassigned

Bug Description

There is a YAOUS setting for circ.hold_stalling_hard "Hard stalling interval" that doesn't seem like it is used, but there is an inconsistency that may cause problems if it ever does get used.

The name for the setting is formatted differently than the name for the soft stalling. The hard stalling ends with an underscore "_hard" while the soft stalling setting ends with a period ".soft".

http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/sql/Pg/950.data.seed-values.sql#l3085
3085 ,( 'circ.hold_stalling.soft', 'holds',
3086 oils_i18n_gettext('circ.hold_stalling.soft',
3087 'Soft stalling interval',
3088 'coust', 'label'),
3089 oils_i18n_gettext('circ.hold_stalling.soft',
3090 'How long to wait before allowing remote items to be opportunistically captured for a hold. Example "5 days"',
3091 'coust', 'description'),
3092 'interval', null)
3093
3094 ,( 'circ.hold_stalling_hard', 'holds',
3095 oils_i18n_gettext('circ.hold_stalling_hard',
3096 'Hard stalling interval',
3097 'coust', 'label'),
3098 oils_i18n_gettext('circ.hold_stalling_hard',
3099 'Holds: Hard stalling interval',
3100 'coust', 'description'),
3101 'interval', null)

Then in Open-ILS/src/perlmods/lib/OpenILS/Const.pm
http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/perlmods/lib/OpenILS/Const.pm
A constant is defined based on the wrong name.

  86 econst OILS_SETTING_HOLD_SOFT_STALL => 'circ.hold_stalling.soft';
  87 econst OILS_SETTING_HOLD_HARD_STALL => 'circ.hold_stalling.hard';

Changing the library setting would probably be the cleanest fix, but since this value isn't used, it is a low priority. I just wanted to document it in case that feature ever does get implemented.. although I'm not sure what a hard stalling interval would mean.

This was seen in 2.8.2 and master.
Josh

Tags: circ-holds
description: updated
Revision history for this message
Jason Etheridge (phasefx) wrote :

I think we should remove the setting.

Revision history for this message
Shula Link (slink-g) wrote :

Confirmed as still present in 2.9.1, and the 'circ.hold_stalling_hard' isn't used in PINES that I can see.

Changed in evergreen:
status: New → Confirmed
tags: added: holds
Revision history for this message
Andrea Neiman (aneiman) wrote :

Since this is not actually used I filed a bug to remove it: https://bugs.launchpad.net/evergreen/+bug/1916297

Dan Briem (dbriem)
tags: added: circ-holds
removed: holds
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.