Inconsistent config.update_coded_value_map() in codebase

Bug #1091831 reported by Dan Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.3
Fix Released
Medium
Unassigned

Bug Description

config.update_coded_value_map() was added to the codebase in two forms (the upgrade different from the schema file):

http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=ea72a97aaa3cfd6bfb3d41c53dae665756f56507

I believe the upgrade is the correct version. New branch is forthcoming to take care of this.

Tags: pullrequest
Revision history for this message
Dan Wells (dbw2) wrote :

Branch to fix is here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1091831_coded_value_map_function_fix

working/user/dbwells/lp1091831_coded_value_map_function_fix

This makes the schema version match the old upgrade, and adds a new upgrade file for anyone unlucky enough to have installed with the bad schema.

As it stands, while the logic is at least functional now, you will get an insert error if you 'add_only' something which is already there, rather than just a notice or warning, but maybe this is the intended behavior. If we decide we want to do something else, we will have to take that on separately.

Changed in evergreen:
milestone: none → 2.4.0-alpha
importance: Undecided → High
Revision history for this message
Dan Wells (dbw2) wrote :

Setting this high, since it is a simple fix and would be nice to get into 2.3.2.

tags: added: pullrequest
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Setting this to medium, since I don't think it is a show stopper, but I agree it should get in by the targeted milestones.

Changed in evergreen:
importance: High → Medium
status: New → Confirmed
status: Confirmed → In Progress
assignee: nobody → Jason Stephenson (jstephenson)
Changed in evergreen:
assignee: Jason Stephenson (jstephenson) → nobody
status: In Progress → Confirmed
Revision history for this message
Dan Scott (denials) wrote :

Thanks Dan! The upgrade applies cleanly to a 2.3.1 install, and I agree that it is a high priority for getting into 2.3.2.

Pushed to master and rel_2_3.

Changed in evergreen:
status: Confirmed → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.