Extra spaces in username/barcode stumps OPAC

I have a fix for this. Even though this is pretty trivial, as an Evergreen newbie, I'd appreciate the opportunity of going through the bug-/code-submission steps just to become familiar with the process.

Hi Dan,

It's great to have new contributors! See here: http://www.open-ils.org/dokuwiki/doku.php?id=contributing , but in short:

If you can
 - push a git branch (branched from *master*, never from a release branch) containing your commits somewhere (ideally the Evergreen "working" repo - ask in IRC for access if needed, but for my part I don't think it really matters where you push as long as the repo is public and available online),
 - be sure your commits are well organized/formatted (there doesn't have to be more than one commit unless you need there to be),
 - have signed-off any commits with git's sign-off feature, thereby asserting accordance with the DCO ( http://www.open-ils.org/dokuwiki/doku.php?id=contributing#developer_s_certificate_of_origin ),
 - put a link to that branch here on launchpad and apply the tag 'pullrequest' to the bug when you're ready for your contribution to be tested,

that should just about cover the essentials of the submission process.

Thanks and welcome!

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dpearl/newspace

To <email address hidden>:working/Evergreen.git
 * [new branch] newspace -> user/dpearl/newspace

commit a99647fa5e72caf4eaeb5a6efcb19740718bc424

Tested and works for me.

Though I'm not too sure about the change to the login form. Even though we'd no longer consider spaces upon submission, I think it's still useful to remind end users not to include spaces via the form's message.

Thank you for the additional testing.
I simplified the login message to keep things as simple as possible for the patron. I like removing "don't"s when I can.

Hi Dan: Thanks for the patch!

On the subject of string changes - please do not change strings in the user interface for a point release unless there is an actual bug that is being fixed. Rationale: string changes generate churn for translators, and while improving the user experience is a great overall goal, we want to confine those kinds of string changes to the master branch.

Thanks, Dan.

Your rationale is sensible.
How do I proceed? Is it:

* Wait a day or so for comments
* Make change in my version and push it again

I now have available a version but without the string change in the menu.

To <email address hidden>:working/Evergreen.git
 + a99647f...021a3bf newspace -> user/dpearl/newspace (forced update)

Same URL
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dpearl/newspace

Works for me. Thanks Dan!

Fix committed to master, rel_2_3, and rel_2_2.