| 2014-06-22 15:48:10 |
Jakub Vaněk |
description |
Hello everybody,
I found a bug when I was playing "Who Says Penguins Can't Fly?". If you start this level as first, ETR will crash. SIGSEGV is fired because TCollidable *trees is NULL in levels with no trees and in CControl::CheckTreeCollisions(...) is that variable indexed.
GDB output:
GNU gdb (Ubuntu 7.7-0ubuntu3.1) 7.7
Copyright (C) 2014 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law. Type "show copying"
and "show warranty" for details.
This GDB was configured as "i686-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /usr/local/bin/etr...done.
(gdb) run
Starting program: /usr/local/bin/etr
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/i386-linux-gnu/libthread_db.so.1".
----------- Extreme Tux Racer 0.6.0 ----------------
----------- (C) 2010-2013 Extreme Tuxracer Team --------
[New Thread 0xb6c93b40 (LWP 15673)]
No function available for obtaining GL proc addresses
[New Thread 0xaebd4b40 (LWP 15679)]
[Thread 0xaebd4b40 (LWP 15679) exited]
[New Thread 0xaebd4b40 (LWP 15680)]
[New Thread 0xb3090b40 (LWP 15681)]
[New Thread 0xaceffb40 (LWP 15682)]
Program received signal SIGSEGV, Segmentation fault.
CControl::CheckTreeCollisions (this=this@entry=0x8bc0fb8, pos=..., tree_loc=tree_loc@entry=0xbffff1f8, tree_diam=tree_diam@entry=0xbffff1f0) at physics.cpp:128
warning: Source file is more recent than executable.
128 size_t tree_type = trees[0].tree_type;
(gdb) backtrace
#0 CControl::CheckTreeCollisions (this=this@entry=0x8bc0fb8, pos=..., tree_loc=tree_loc@entry=0xbffff1f8, tree_diam=tree_diam@entry=0xbffff1f0)
at physics.cpp:128
#1 0x0808ed70 in CControl::AdjustTreeCollision (this=0x8bc0fb8, pos=..., vel=vel@entry=0xbffff380) at physics.cpp:179
#2 0x08090d4d in CControl::SolveOdeSystem (this=this@entry=0x8bc0fb8, timestep=timestep@entry=0,0050001144409179688) at physics.cpp:627
#3 0x0809132c in CControl::UpdatePlayerPos (this=this@entry=0x8bc0fb8, timestep=timestep@entry=0,0050001144409179688) at physics.cpp:670
#4 0x080986ad in CRacing::Loop (this=0x80cfff0 <Racing>, time_step=0,0050001144409179688) at racing.cpp:320
#5 0x080a3158 in State::Manager::CallLoopFunction (this=this@entry=0x80d0268 <State::manager>) at states.cpp:130
#6 0x080a31af in State::Manager::Run (this=0x80d0268 <State::manager>, entranceState=...) at states.cpp:40
#7 0x0804dfbe in main (argc=1, argv=0xbffff654) at main.cpp:98
Patch is in attachments.
Please correct me if CControl::CheckTreeCollisions(...) quit isn't ok.
Thank you,
Jakub Vanek |
Hello everybody,
I found a bug when I was playing "Who Says Penguins Can't Fly?". If you start this level as first, ETR will crash. SIGSEGV is fired because TCollidable *trees is NULL in levels with no trees and in CControl::CheckTreeCollisions(...) is that variable indexed.
Patch is in attachments.
Please correct me if CControl::CheckTreeCollisions(...) quit isn't ok.
Thank you,
Jakub Vanek |
|
