Enblend fails to recognise output tiff file too large.

Bug #685885 reported by rew
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Enblend
New
Undecided
Unassigned

Bug Description

I'm working on a big blend. I specified the output resolution to be: 62930*17113
This results in 4.01 Gb of output pixel data. With --compression NONE, this is
guaranteed to generate more than a TIFF file can handle.

First I would like enblend to signal this before it's done hours worth of blending.

Secondly, it silently wrote the invalid TIFF file without any complaint. It should
at least fail writing the final output image. I was anxious to see the partial result
when I found out the tiff wouldn't open....

Revision history for this message
cspiel (cspiel-users) wrote :

You have mingled two issues in one report.

(1) Enblend does not warn early, if the output image
will overwhelm the selected output format.

(2) Neither Enblend nor Enfuse clean up a half-done
output image, if they unexpectedly die or they are
interrupted by the user.

Issue (1): In the general case this is a complicated
problem that requires (a) finding out about the
final image size as early in the process as possible
and (b) knowing the size limits of all possible output
image formats with respect to their actual libraries.

Issue (2) should be fixed in rev236fd8c3e767.

Revision history for this message
rew (r-e-wolff) wrote :

Let's consider the "issue 2" as "fix released" and continue this discussion on "issue 1" as you call it.

restrictions that I know of right now, is 4Gb of pixel data for TIFF files and 64k pixels per side for JPG.

How about if we make this a warning.

if (((height * width * estimate_for_bytes_per_pixel) > 2LL^32)) &&
     (outputformat == TIFF)) {
    ..... WARNING: possibly generating more than 4Gb of pixel data. May not fit in output TIFF file.
}
if (((width > 65500) ||
     (height > 65500)) &&
    (outputformat == JPG)) {
   ..... WARNING: JPG format may not support the output image size.
}

Then it isn't as critical, and doesn't have to be 100% right. We can easily add checks for limits on other output formats as we go along.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.