editmoin

Doesn't work with latest moin over https

Bug #801284 reported by James Westby
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
editmoin
New
Undecided
Unassigned
editmoin (Ubuntu)
Fix Released
Undecided
Martin Pitt

Bug Description

It looks like the latest moin (e.g. wiki.canonical.com) over https has changed cookiename
to MOIN_SESSION_443_ROOT.

Something like

=== modified file 'editmoin'
--- editmoin 2011-04-11 16:51:49 +0000
+++ editmoin 2011-06-23 18:45:57 +0000
@@ -461,6 +461,9 @@
     else:
         # Moin < 1.7
         cookievalue = get_id(url)
+ cookiename = "MOIN_SESSION"
+ if url.startswith("https://"):
+ cookiename = "MOIN_SESSION_443_ROOT"
         urlopener = get_urlopener(url, cookievalue)

     moinfile = fetchfile(urlopener, url, cookievalue, template)

seems to work for this latest moin.

Thanks,

James

Revision history for this message
James Westby (james-w) wrote :

Obviously passing the new cookiename to the get_urlopener function.

Thanks,

James

Revision history for this message
Andy Whitcroft (apw) wrote :

Ok I've found that we have an inconsistent situation when the wiki.ubuntu.com requires the cookie to be MOIN_SESSION_80_ROOT even over https, whereas wiki.canonical.com requires it to be MOIN_SESSION_443_ROOT over https. This seems to be a fail.

I've played with this and put together a patch which just tries all three in order till one works. This seems to work for me on all the pages I've tried.

Revision history for this message
Andy Whitcroft (apw) wrote :
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks for this! I'll pull this patch into the Debian/Ubuntu packages.

Changed in editmoin (Ubuntu):
assignee: nobody → Martin Pitt (pitti)
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package editmoin - 1.17-1

---------------
editmoin (1.17-1) unstable; urgency=low

  * New upstream release:
    - Use sensible-editor instead of vi to pick up the system level editor
      preference.
    - Add support for URLs that include query parameters.
  * Switch to 3.0 source package format.
  * Move inline change to editmoin.1 to 01_man_ids_from_firefox.patch. Also
    update it to catch cookies like "MOIN_SESSION_443_ROOT".
  * Move moin-plugin.vim into debian/, to work better for 3.0 source.
  * debian/control: Bump Standards-Version to 3.9.2.
  * Add 02_alternative_cookie_names.patch: Current moin versions use
    MOIN_SESSION_80_ROOT or MOIN_SESSION_443_ROOT cookie names. Try these
    before the standard MOIN_SESSION cookie. Thanks Andy Whitcroft for the
    patch! (LP: #801284)
  * debian/editmoin.install, debian/rules: Simplify installation of vim
    plugin.
  * Add bzr-builddeb configuration (merge mode).
 -- Martin Pitt <email address hidden> Wed, 06 Jul 2011 07:04:53 +0200

Changed in editmoin (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Patches

Remote bug watches

Bug watches keep track of this bug in other bug trackers.