Dulwich

C extensions should not be compiled under pypy

Bug #881546 reported by Jonas Obrist
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Dulwich
Fix Released
Medium
Unassigned
Dulwich 0.8.1

Bug Description

When installing dulwich under pypy, the C extensions actually slow down dulwich rather than speeding it up. I had code going almost twice as fast by removing all the .so files in dulwich when running under pypy.

So ideally, when dulwich is installed under pypy, it should not compile C extensions.

Related branches

lp://staging/~ronny-pfannschmidt-deactivatedaccount/dulwich/pypy
VCS imports: Pending requested
Diff: 12 lines (+1/-1)
1 file modified
setup.py (+1/-1)
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Are you sure this is the case? As far as I understand the extensions are ignored by pypy anyway.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

gwenhwyvar:~/src/dulwich/trunk% PYTHONPATH=. pypy -c 'import dulwich._objects'
Traceback (most recent call last):
  File "app_main.py", line 53, in run_toplevel
  File "app_main.py", line 533, in run_it
  File "<string>", line 1, in <module>
ImportError: No module named dulwich._objects
gwenhwyvar:~/src/dulwich/trunk% PYTHONPATH=. python -c 'import dulwich._objects'

Changed in dulwich:
status: New → Triaged
importance: Undecided → Medium
status: Triaged → Incomplete
Revision history for this message
ronny (ronny-pfannschmidt-deactivatedaccount) wrote :

pypy doesn't if you had c extensions it will behave as close as possible to a propper python

Revision history for this message
ronny (ronny-pfannschmidt-deactivatedaccount) wrote :

did you just try to import something compiled against cpython into pypy?!?! its NOT ABI compatible

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

No, but it looks like my pypy installation is actually broken - and thus I wasn't getting any extensions anyway.

Changed in dulwich:
status: Incomplete → Opinion
status: Opinion → Triaged
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Merged, thanks!

Changed in dulwich:
status: Triaged → Fix Committed
milestone: none → 0.8.1
assignee: nobody → ronny (ronny-pfannschmidt)
Jelmer Vernooij (jelmer)
Changed in dulwich:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.