add unit test for Dot.py replacement()
Bug #1023564 reported by
Kyle Nitzsche
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| dotdepends |
Fix Committed
|
Medium
|
Mike Carifio | ||
Bug Description
1) replacement() should be have a unit test that verifies a range of known invalid dot node names are returned as valid dot node names.
2) the function should have a more descriptive name, perhaps pkg2dotNode(),.
3) Extra credit, the Dot class should perhaps have a dictionary whose key is the node name and whose value is the pkg name.
Related branches
lp://staging/~knitzsche/dotdepends/addresses-mfisch-review
- Matt Fischer (community): Approve
-
Diff: 622 lines (+262/-185)6 files modifiedDotdepends/Dot.py (+25/-18)
debian/changelog (+6/-0)
debian/copyright (+1/-1)
debian/rules (+2/-1)
usr/bin/dotdepends (+30/-14)
usr/bin/dotdepends-merge (+198/-151)
Revision history for this message
| Kyle Nitzsche (knitzsche) wrote | #1 |
| Changed in dotdepends: | |
| assignee: | nobody → Mike Carifio (carifio) |
Revision history for this message
| Mike Carifio (carifio) wrote | #2 |
| Changed in dotdepends: | |
| status: | Confirmed → Fix Committed |
| Changed in dotdepends: | |
| status: | Fix Committed → In Progress |
Revision history for this message
| Mike Carifio (carifio) wrote | #3 |
| Changed in dotdepends: | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
Mike, if interested... a unit test here. Else assign back to me.