Epetra Sparsity builder renders assemble argument "bool finalize" useless

Bug #891452 reported by Andre Massing
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
DOLFIN
New
Undecided
Unassigned

Bug Description

in void EpetraMatrix::init(const GenericSparsityPattern& sparsity_pattern) the lines

 try
  {
    // Finalise map. Here, row_map is standing in for RangeMap, which is
    // probably ok but should be double-checked.
    matrix_map.GlobalAssemble(domain_map, row_map);
    matrix_map.OptimizeStorage();
  }

causes the matrix_map to be filled/finalized according to
http://trilinos.sandia.gov/packages/docs/r10.8/packages/epetra/doc/html/classEpetra__FECrsGraph.html#a59a372d227393f5f54c5ff7917806813
having the signature is
int GlobalAssemble (const Epetra_Map &domain_map, const Epetra_Map &range_map, bool callFillComplete=true)

A filled matrix_map in turn will trigger an automatic fill of the matrix and thereby making
the argument bool finalize in the assemble function useless if Epetra is used as backend.
This should be made consistent.

Andre Massing (massing)
description: updated
Changed in dolfin:
status: New → Opinion
Andre Massing (massing)
Changed in dolfin:
status: Opinion → New
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.