DiCe!++

Open own list when using get/browse file list on self

Bug #1225420 reported by inactive on 2013-09-14

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	DC++	Fix Released	Wishlist	Unassigned
	DiCe!++	In Progress	Undecided	Unassigned

Bug Description

Feature|Mod

Issue: When attempting to "download" your own filelist via the userlist (rightclick -> get filelist) you're greeted with the status/warning-message: "You're trying to download from yourself!" and the action is thus canceled.

Suggestion: If it's not meant to be used then either remove it or change it so that the user can OPEN his own list via the user-list menu.

See original description

inactive (inactive.-deactivatedaccount) on 2013-09-14

description:	updated
description:	updated
description:	updated

inactive (inactive.-deactivatedaccount) on 2013-09-14

summary:	- "You're trying to download from yourself!" + Feat\|Mod: "You're trying to download from yourself!"
description:	updated
description:	updated
description:	updated

inactive (inactive.-deactivatedaccount) on 2013-09-14

description:

updated

Revision history for this message

eMTee (realprogger) wrote on 2013-09-14: Re: Feat|Mod: "You're trying to download from yourself!"

It's the same error message you get from any lists, actually it's generated when you try to add yourself as a source for any queue item.
The message itself is OK, however it would be nice to either remove the file list related context menus for own CID or better open the own list instead of trying to add a filelist item to the queue.

Changed in dcplusplus:
status:	New → Confirmed
importance:	Undecided → Wishlist

iceman50 (bdcdevel) on 2013-09-15

Changed in diceplusplus:
status:	New → In Progress

Fredrik Ullner (ullner) on 2013-11-12

summary:

- Feat|Mod: "You're trying to download from yourself!"
+ Open own list when using get/browse file list on self

Revision history for this message

Fredrik Ullner (ullner) wrote on 2013-11-12:

dcpp_getownlist.diff Edit (6.2 KiB, text/plain)

Attached patch is using an exception as system logic. I don't know if this is acceptable or not, it was simply to avoid having to check for 'self' multiple times.

Changed in dcplusplus:
status:	Confirmed → In Progress

Revision history for this message

poy (poy) wrote on 2013-11-12:

that's inventive... it's fine by me. :)

however:

1) make QueueSelfException derive from QueueException instead of Exception, so that callers catching QueueException would still be able to receive QueueSelfExceptions.

2) can you check how this works from searches and finished transfer windows? these use WinUtil::addUserItems, which might benefit from these changes as well.

Revision history for this message

Fredrik Ullner (ullner) wrote on 2013-11-12: