Dexter - Old

Only allow numbers and symbols in phone numbers

Bug #684507 reported by Danielle Foré
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Dexter - Old
Confirmed
Low
Allen Lowe

Bug Description

At the moment you can make a phone number that consists of the text "sdfsfsdfsg". This shouldn't really be possible. Phone numbers should only consist of number and symbols like so "+1 (343) 532-3456"

Allen Lowe (lallenlowe)
Changed in dexter-rolodex:
assignee: nobody → Allen Lowe (lallenlowe)
importance: Undecided → Low
status: New → In Progress
status: In Progress → Fix Committed
Revision history for this message
Cris Dywan (kalikiana) wrote :

Speaking from a bit of experience with phone number handling:

Numbers can be 0-9 as well as Hindic and Arabic numbers, so validity needs to check for unicode numbers.
Symbols can be: p#*+
Meaningless characters used in numbers: ()/- and spaces

Cris Dywan (kalikiana)
Changed in dexter-rolodex:
status: Fix Committed → In Progress
Revision history for this message
Allen Lowe (lallenlowe) wrote : Re: [Bug 684507] Re: Only allow numbers and symbols in phone numbers

I disagree, many people will try to use several of those symbols
legitimately

Revision history for this message
Danielle Foré (danrabbit) wrote :

I also think we need to be careful about which symbols we blacklist. It's possible that we aren't taking into consideration that phone number formatting is kind of localized as well.

Revision history for this message
Allen Lowe (lallenlowe) wrote :

I have to say, I don't see the point of trying to figure out which symbols are used in every dialect of every language, and by every individual. Currently all I do is block alpha characters, and there is no reason to make it more complicated than that
--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.

Revision history for this message
Cris Dywan (kalikiana) wrote :

Yes there is a reason. "p" is used in numbers but right now it is blocked. That is why I tried to provide a list of what numbers can contain.

Also pasting needs to be validated.

Revision history for this message
Allen Lowe (lallenlowe) wrote :

ok, well, that makes sense. I am going to revert this change for the 0.1 release, as it is better to allow the wrong characters than to block the wrong characters. I will fix this later

Changed in dexter-rolodex:
status: In Progress → Confirmed
Revision history for this message
Adrien Plazas (kekun-plazas) wrote :

What about SIP adresses/numbers ?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.