Strip whitespace from the "Package name(s):" field in the exhibits editor
Bug #1043152 reported by
David Planella
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Developer registration portal |
New
|
Undecided
|
Unassigned | ||
| software-center (Ubuntu) |
Fix Released
|
Medium
|
Michael Vogt | ||
Bug Description
I set up and published an exhibit for multiple packages yesterday, and had some fun this morning debugging why the exhibit was not visible on the client.
It turns out that (apart from some other issues on the client, discussed with mvo on IRC) the client cannot display multiple packages for download if there is whitespace between the comma-separated list. That is:
* 'lightread, fogger, picsaw' <- does not work
* 'lightread,
In order to be a bit more robust, I think the server should strip the whitespace before publishing the JSON for the client to consume. Alternatively, the client could also do the stripping, so I'm adding a task for it too.
Related branches
lp://staging/~mvo/software-center/lp1043152
- Gary Lasker (community): Approve
-
Diff: 69 lines (+27/-10)2 files modifiedsoftwarecenter/backend/scagent.py (+3/-2)
tests/test_scagent.py (+24/-8)
| Changed in software-center (Ubuntu): | |
| status: | New → In Progress |
| importance: | Undecided → Medium |
| Changed in software-center (Ubuntu): | |
| assignee: | nobody → Michael Vogt (mvo) |
| Changed in software-center (Ubuntu): | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in software-center (Ubuntu): | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package software-center - 5.3.10
---------------
software-center (5.3.10) quantal; urgency=low
[ Robert Roth ]
* lp:~evfool/software-center/lp1034894:
- Set the linked style class to the back and forward buttons as
requested in bug #1034894.
[ Michael Vogt ]
* lp:~mvo/software-center/fix-more-dep8,
lp:~mvo/software-center/more-dep8-again:
- additional set of updates to fix issues in the
dep8/ADT test runs on jenkins
* lp:~mvo/software-center/fix-chroot-lp1040311:
- fix crash if there is no system dbus, this can
happen e.g. when running inside a chroot
environment (LP: #1040311)
* lp:~mvo/software-center/recagent-test-cleanup:
- consolidate code in test_recagent into common
functions
* lp:~mvo/software-center/lp1043152:
- ensure that any white space is properly stripped from
package lists received from the agent (LP: #1043152)
* lp:~mvo/software-center/auto-fill-email-for-login:
- allow auto-fill of the email in login.ubuntu.com if
we have it (LP: #1042279)
* tests/gtk3/
- fix patching of softwarecenter.
* softwarecenter/
- fix SEGV in tests/gtk3/
parent object properly
[ Gary Lasker ]
* lp:~gary-lasker/software-center/recommender-panel-visual-tweaks:
- add support for two sizes of spinner to the spinner widget and use
the smaller one for the lobby/category screen panels
* lp:~gary-lasker/software-center/update-to-latest-recommender-client:
- update to the latest recommender client API from
lp:~canonical-ca-hackers/ubuntu-recommender/ubuntu-recommender-client
and replaces the deprecated recommend_me call with the new recommend_me
call that includes the UUID
* lp:~gary-lasker/software-center/recommender-unit-test-updates:
- update unit test to accomodate the new subcategory that has been
added to the themes and tweaks category
-- Michael Vogt <email address hidden> Thu, 30 Aug 2012 10:22:58 +0200