Powerdns filters on models.Records vs Record

Bug #1285227 reported by Endre Karlson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Undecided
Endre Karlson
Icehouse
Fix Released
Undecided
Endre Karlson

Bug Description

    # RecordSet Methods
    def update_recordset(self, context, domain, recordset):
        # Ensure records are updated
        values = {'ttl': recordset['ttl']}

        query = self.session.query(models.Records)
        query.filter_by(designate_recordset_id=recordset['id']).update(values)

        self._update_soa(domain)

    def delete_recordset(self, context, domain, recordset):
        # Ensure records are deleted
        query = self.session.query(models.Records)
        query.filter_by(designate_recordset_id=recordset['id']).delete()

        self._update_soa(domain)

This makes the update or deletion fail of a rrset.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/76570

Changed in designate:
assignee: nobody → Endre Karlson (endre-karlson)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/76570
Committed: https://git.openstack.org/cgit/stackforge/designate/commit/?id=4f98263f4baa99224d32c4866f8b8d551977de67
Submitter: Jenkins
Branch: master

commit 4f98263f4baa99224d32c4866f8b8d551977de67
Author: Endre Karlson <email address hidden>
Date: Wed Feb 26 17:07:46 2014 +0100

    Fixes filtering in delete and update in PowerDNS

    Change-Id: I9bcf798604de6ff91919eff2cd7e3f2c61180f08
    Closes-Bug: #1285227

Changed in designate:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.