Designate should 400 on a SPF record data with trailing backlash
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Designate |
Triaged
|
High
|
Unassigned |
Bug Description
To reproduce, post an SPF recordset where the record data ends in a trailing slash:
{
"name" : "foospf.
"description" : "An SPF recordset.",
"type" : "SPF",
"ttl" : 3600,
"records" : [
"v=spf1 +all\\"
]
}
The recordset will not 400 like it should. It will go to an ERROR status. Looking at mini dns logs, I see:
2016-02-10 23:46:55.326 TRACE designate.service Traceback (most recent call last):
2016-02-10 23:46:55.326 TRACE designate.service File "/root/
2016-02-10 23:46:55.326 TRACE designate.service {'payload': payload, 'addr': addr}):
2016-02-10 23:46:55.326 TRACE designate.service File "/root/
2016-02-10 23:46:55.326 TRACE designate.service for response in self.applicatio
2016-02-10 23:46:55.326 TRACE designate.service File "/root/
2016-02-10 23:46:55.326 TRACE designate.service for response in self._handle_
2016-02-10 23:46:55.326 TRACE designate.service File "/root/
2016-02-10 23:46:55.326 TRACE designate.service [str(record[4])], # rdata
2016-02-10 23:46:55.326 TRACE designate.service File "/root/
2016-02-10 23:46:55.326 TRACE designate.service rd = dns.rdata.
2016-02-10 23:46:55.326 TRACE designate.service File "/root/
2016-02-10 23:46:55.326 TRACE designate.service return cls.from_
2016-02-10 23:46:55.326 TRACE designate.service File "/root/
2016-02-10 23:46:55.326 TRACE designate.service token = tok.get(
2016-02-10 23:46:55.326 TRACE designate.service File "/root/
2016-02-10 23:46:55.326 TRACE designate.service raise dns.exception.
2016-02-10 23:46:55.326 TRACE designate.service UnexpectedEnd
2016-02-10 23:46:55.326 TRACE designate.service
This is running with bind + agent, on commit commit b16fadeb801766d
The expected behavior here is to 400 on SPF records with trailing slashes.
Also, see these functional test logs: See these functional test logs: http://
Changed in designate: | |
milestone: | mitaka-3 → mitaka-2 |
milestone: | mitaka-2 → none |
Related fix proposed to branch: master /review. openstack. org/278801
Review: https:/