mdns.get_serial_number retries for no reason
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Designate |
In Progress
|
High
|
Kiall Mac Innes |
Bug Description
The idea of "get_serial_number" in MiniDNS is that the Pool Manager can get the status of a zone on a nameserver at any time, synchronously, as a replacement for a cache value that it doesn't know.
https:/
This is going to be seriously hampered if, during the quick, "get me the serial", mdns compares the first serial it gets against
the one randomly hanging around in the zone object:
https:/
if actual_serial is None or actual_serial < zone.serial:
# TODO(vinod): Account for serial number wrap around.
if retries > 0:
else:
# Everything looks good at this point. Return SUCCESS.
This should simply return the first serial number it sees, because that's what the pool manager wants to know.
Unless I'm mistaken about the idea behind this function.
Changed in designate: | |
status: | New → Triaged |
importance: | Undecided → High |
milestone: | none → mitaka-2 |
Changed in designate: | |
assignee: | nobody → sonu (sonu-bhumca11) |
Changed in designate: | |
assignee: | sonu (sonu-bhumca11) → Kiall Mac Innes (kiall) |
Changed in designate: | |
milestone: | mitaka-2 → none |
Fix proposed to branch: master /review. openstack. org/270690
Review: https:/