The "gendelta" command should abort as opposed to generating broken deltas
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
pristine-tar (Debian) |
New
|
Unknown
|
|||
pristine-tar (Ubuntu) |
Confirmed
|
Undecided
|
Unassigned |
Bug Description
Binary package hint: pristine-tar
When a file is missing from the unpacked source tree "pristine-tar gendelta" will happily generate a (broken) delta without as much of a warning. It should abort with an error instead.
The error can be reproduced easily:
{{{
$ apt-get source apg
Reading package lists... Done
Building dependency tree
Reading state information... Done
Need to get 90.2kB of source archives.
Get: 1 http://
Get: 2 http://
Get: 3 http://
Fetched 90.2kB in 0s (208kB/s)
dpkg-source: info: extracting apg in apg-2.2.3.dfsg.1
dpkg-source: info: unpacking apg_2.2.
dpkg-source: info: applying apg_2.2.
$ cd apg-2.2.3.dfsg.1/
$ rm README.CYGWIN
$ pristine-tar gendelta ../apg_
$ echo $?
0
$ rm ../apg_
$ pristine-tar gentar ../brokendelta ../apg_
tar: apg-2.2.
tar: Exiting with failure status due to previous errors
pristine-tar: command failed: tar cf /tmp/pristine-
}}}
Related branches
- James Westby (community): Disapprove
-
Diff: 33063 lines5 files modifiedPtutils.pm (+283/-0)
pristine-tar (+40/-12)
t/gendelta.t (+23/-0)
test/fixed-package-list-2.txt (+32547/-0)
test/pt-test.sh (+66/-0)
Changed in pristine-tar (Debian): | |
status: | Unknown → New |
Changed in pristine-tar (Ubuntu): | |
status: | New → In Progress |
assignee: | nobody → Muharem Hrnjadovic (al-maisan) |
Changed in pristine-tar (Ubuntu): | |
status: | In Progress → Confirmed |
Changed in pristine-tar (Ubuntu): | |
assignee: | Muharem Hrnjadovic (al-maisan) → nobody |
Related bug #417153.