Debian
libvirt package

Enable NUMA support in arm64 builds

Bug #1627926 reported by dann frazier on 2016-09-27

This bug affects 1 person

	Status	Importance	Assigned to
libvirt (Debian)	New	Unknown	debbugs #838494
libvirt (Ubuntu)	Fix Released	High	dann frazier
Xenial	Fix Released	High	Stefan Bader

Bug Description

[Impact]
The host capabilities for arm64 NUMA systems are incomplete - one effect of which is that nova is unable to make use of hugetlbfs for backing VMs with huge pages.

[Test Case]
Examine the output of 'virsh capabilities' on an arm64 NUMA system. The topology section for all but the first node are currently inaccurate and lacks page size entries. Sample output from a 2-node NUMA system is attached, both pre and post fix.

[Regression Risk]
Risk is minimized by the fact that this change is just enabling the same code for arm64 that is already enabled for the other NUMA-enabled Ubuntu architectures.

[racb] What if, for example, numa support is completely broken on arm64 and this is why it was disabled? By landing this, we could be regressing arm64 support.

See original description

Tags:

dann frazier (dannf) on 2016-09-27

Changed in libvirt (Ubuntu Xenial):
status:	New → Confirmed
importance:	Undecided → High
assignee:	nobody → dann frazier (dannf)

Revision history for this message

dann frazier (dannf) wrote on 2016-09-27:

virsh-capabilities.orig Edit (9.4 KiB, text/html)

Revision history for this message

dann frazier (dannf) wrote on 2016-09-27:

virsh-capabilities Edit (12.0 KiB, text/html)

Bug Watch Updater (bug-watch-updater) on 2016-09-27

Changed in libvirt (Debian):
status:	Unknown → New

dann frazier (dannf) on 2016-09-28

Changed in libvirt (Ubuntu):
status:	Confirmed → In Progress

Revision history for this message

Christian Ehrhardt  (paelzer) wrote on 2016-09-29:

Hi Dann, please check how much that would need the on top that is in bug 1621121.

If you just want to get where others already are I think you are fine.
If you expect all numa* stuff the other bug is missing for you (as well as for the others).

Revision history for this message

dann frazier (dannf) wrote on 2016-09-29: Re: [Bug 1627926] Re: Enable NUMA support in arm64 builds

On Thu, Sep 29, 2016 at 9:47 AM, ChristianEhrhardt
<email address hidden> wrote:
> Hi Dann, please check how much that would need the on top that is in bug
> 1621121.
>
> If you just want to get where others already are I think you are fine.
> If you expect all numa* stuff the other bug is missing for you (as well as for the others).

Christian,
My use case (hugepage-backed VMs via nova) just requires what others
already have.

Changed in libvirt (Ubuntu Xenial):
assignee:	dann frazier (dannf) → Stefan Bader (smb)
Changed in libvirt (Ubuntu):
status:	In Progress → Fix Committed

Revision history for this message

Stefan Bader (smb) wrote on 2016-09-30:

Changes for Xenial, I have added to smb/xenial branch. Would delay the upload until the current proposed clears.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-10-01:

This bug was fixed in the package libvirt - 2.1.0-1ubuntu8

---------------
libvirt (2.1.0-1ubuntu8) yakkety; urgency=medium

[ Christian Ehrhardt ]

  * avoid migration postcopy issues by ensuring valid commands (LP: #1620906)
    - d/p/ubuntu/check-live-for-postcopy.patch Check for --live flag for
      postcopy-after-precopy migration.
    - d/p/ubuntu/make-postcopy-mandatory-for-postcopy-after-precopy.patch to

[ Stefan Bader ]

  * Fix Xenial to Yakkety migration from libvirt-bin.service to
    libvirtd.service (LP: #1627969).
  * Update Vcs-Git and Vcs-Browser fields to point to launchpad
    (LP: #1629210)

[ Dann Frazier ]

* Fix FTBS in Yakkety due to missing python dependency (LP: #1629041)

libvirt (2.1.0-1ubuntu7) yakkety; urgency=medium

* Enable NUMA support in arm64 builds (LP: #1627926).

-- Stefan Bader <email address hidden> Fri, 30 Sep 2016 10:11:30 +0200

Changed in libvirt (Ubuntu):
status:	Fix Committed → Fix Released

Stefan Bader (smb) on 2016-10-05

Changed in libvirt (Ubuntu Xenial):
status:	Confirmed → Fix Committed

Revision history for this message

Brian Murray (brian-murray) wrote on 2016-10-05: Please test proposed package

Hello dann, or anyone else affected,

Accepted libvirt into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/1.3.1-1ubuntu10.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags:

added: verification-needed

dann frazier (dannf) on 2016-10-06

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Martin Pitt (pitti) wrote on 2016-10-10:

Hello dann, or anyone else affected,

Accepted libvirt into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/1.3.1-1ubuntu10.5 in a few hours, and then in the -proposed repository.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags:	removed: verification-done
tags:	added: verification-needed

Stefan Bader (smb) on 2016-10-10

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Robie Basak (racb) wrote on 2016-10-19:

Was this tested on arm64 please? I feel we should. What if, for example, numa support is completely broken on arm64 and this is why it was disabled? By landing this, we could be regressing arm64 support if we don't test it.

Please test (or confirm tested) on arm64 and then mark v-d.

tags:	added: verification-needed removed: verification-done
description:	updated

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-10-19:

#10

This bug was fixed in the package libvirt - 1.3.1-1ubuntu10.5

---------------
libvirt (1.3.1-1ubuntu10.5) xenial; urgency=medium

* Fix libvirt-guest.sh to handle multiple guests (LP: #1591695).

libvirt (1.3.1-1ubuntu10.4) xenial; urgency=medium

[ Dann Frazier ]

* Enable NUMA for arm64 (LP: #1627926).

[ Stefan Bader ]

* Update Vcs lines to point to launchpad (LP: #1629210).

-- Stefan Bader <email address hidden> Thu, 06 Oct 2016 13:07:20 +0200

Changed in libvirt (Ubuntu Xenial):
status:	Fix Committed → Fix Released

Revision history for this message

dann frazier (dannf) wrote on 2016-10-19:

#11

1.3.1-1ubuntu10.4 was tested on arm64.

tags:

added: verification-done
removed: verification-needed

Revision history for this message

dann frazier (dannf) wrote on 2016-10-19:

#12

A little more detail - NUMA has been supported in the kernel since 4.5 upstream (backported to xenial's 4.4), and is required for hardware such as Cavium ThunderX dual-socket systems.