DC++

Wrong total number of slots reported due to extra search result dupe[ADC]

Bug #1854309 reported by Delion
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DC++
Confirmed
Low
Unassigned

Bug Description

Search on ADC hubs only.

So, 1 TTH.

5 hits.

4 unique users, one with 2 slots skipped (he has that file duplicated actually)

Real slots: 3+2+1=6

Displayed slots: 8 (3+2*2+1).

Why X/0 btw...

See original description
Revision history for this message
Delion (delion) wrote :
Delion (delion)
description: updated
Revision history for this message
eMTee (realprogger) wrote :

The code counting the slots is probably just blatantly adds up the numbers in the children rows. It should skip same results coming from ADC clients; for NMDC or mixed results you can't properly detect same clients.
It is X/0 because the ADC Search result does not include the total number of opened slots, only the number of free ones so it always show 0 for ADC results. IIRC the reason is that in long term, people developing ADC planned to do away with the concept of slots at all.

Changed in dcplusplus:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
eMTee (realprogger) wrote :

I could reproduce this situation with pure ADC search results and actually it isn't really the slots counting where the problem lies.
It appears that the dupe removal in SearchFrame::addResult is not quite/always working when there are same results returned from multiple users on multiple ADC hubs.
There is an extra search result here which should not be added, hence the wrong slots count.

eMTee (realprogger)
summary: - Wrong total number of slots reported [ADC]
+ Wrong total number of slots reported due to extra search result
+ dupe[ADC]
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.