cache all data for the day to reduce net calls
Bug #1500486 reported by
Kyle Nitzsche
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Day Scope |
Fix Released
|
High
|
Penk Chen | ||
Bug Description
The day scope currently caches lunar data, but it should cache all data for the current day and use the cache for every refresh after the first on each day.
Related branches
lp://staging/~day-scope-team/day-scope/fixes-1500486-cache-sun-info
- Jin (community): Approve
-
Diff: 433 lines (+186/-70)4 files modifiedCMakeLists.txt (+2/-2)
include/query.h (+10/-4)
src/CMakeLists.txt (+6/-6)
src/query.cpp (+168/-58)
Revision history for this message
| Kyle Nitzsche (knitzsche) wrote | #1 |
| Changed in day-scope: | |
| status: | New → In Progress |
| Changed in day-scope: | |
| importance: | Undecided → High |
| assignee: | nobody → Kyle Nitzsche (knitzsche) |
Revision history for this message
| Kyle Nitzsche (knitzsche) wrote | #3 |
| Changed in day-scope: | |
| status: | In Progress → Fix Committed |
| assignee: | Kyle Nitzsche (knitzsche) → Penk Chen (penk) |
Revision history for this message
| Kyle Nitzsche (knitzsche) wrote | #4 |
Revision history for this message
| Penk Chen (penk) wrote | #5 |
| Changed in day-scope: | |
| assignee: | Penk Chen (penk) → Elsa Wang (elsawang) |
Revision history for this message
| Elsa Wang (elsawang) wrote | #6 |
| Changed in day-scope: | |
| assignee: | Elsa Wang (elsawang) → Ethan Chang (ethan.chang) |
Revision history for this message
| Ethan Chang (ethan.chang) wrote | #7 |
| tags: | added: cqa-verified |
| Changed in day-scope: | |
| assignee: | Ethan Chang (ethan.chang) → Penk Chen (penk) |
Revision history for this message
| Kyle Nitzsche (knitzsche) wrote | #8 |
Revision history for this message
| Kyle Nitzsche (knitzsche) wrote | #9 |
| Changed in day-scope: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Note: using cached data is important for speed, especially since this scope is the first scope in Today scope and any delay here delays the rest of Today scope's categories from displaying.