util.sanitize_source truncates squashfs source types
Bug #1851271 reported by
Chad Smith
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| curtin |
Fix Committed
|
Low
|
Unassigned | ||
Bug Description
When source contains the prefix squashfs:something util.santize_source trucates the uri returned to a single character
python3 -c 'from curtin.util import sanitize_source; print(sanitize_
{'type': 'fsimage', 'uri': 'm'}
Related branches
~danudey/curtin:squashfs_prefix_fix
- Ryan Harper (community): Approve
- Server Team CI bot: Approve (continuous-integration)
-
Diff: 70 lines (+18/-5)3 files modifiedcurtin/util.py (+8/-2)
doc/topics/config.rst (+4/-0)
tests/unittests/test_util.py (+6/-3)
Revision history for this message
| Ryan Harper (raharper) wrote | #1 |
| Changed in curtin: | |
| importance: | Undecided → Low |
| status: | New → Triaged |
| summary: |
- util.santitize_source truncates squashfs source types + util.sanitize_source truncates squashfs source types |
Revision history for this message
| Server Team CI bot (server-team-bot) wrote | #2 |
| Changed in curtin: | |
| status: | Triaged → Fix Committed |
To post a comment you must log in.
Thanks for filing the bug. The 'squashfs:' prefix is currently unsupported.
The correct way to specify a squashfs source is via fsimage:// or http://
For example:
>>> util.sanitize_
{'type': 'fsimage', 'uri': '///nfsmount/
>>> util.sanitize_
{'type': 'fsimage', 'uri': 'http://
That said, we should fix the bug and add the prefix and suffix feature to
the documentation.