Obvious copy-paste bug in libhildon-nonmaemo-gtk3 revision 2001 hildon-pannable-area.c

Bug #1006577 reported by David Barksdale
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cordia HD
New
Undecided
Unassigned

Bug Description

These are the relevent hunks from revision 2001:

@@ -1911,7 +1780,9 @@
   GList *c, *children;
   GdkWindow *selected_window = NULL;

- gdk_drawable_get_size (GDK_DRAWABLE (window), &width, &height);
+ width = gdk_window_get_width (window);
+ height = gdk_window_get_height (window);
+
   if ((x < 0) || (x >= width) || (y < 0) || (y >= height))
     return NULL;

@@ -1929,7 +1800,8 @@
     GdkWindow *child = (GdkWindow *) c->data;
     gint wx, wy;

- gdk_drawable_get_size (GDK_DRAWABLE (child), &width, &height);
+ width = gdk_window_get_width (window);
+ height = gdk_window_get_height (window);
     gdk_window_get_position (child, &wx, &wy);

     if ((x >= wx) && (x < (wx + width)) && (y >= wy) && (y < (wy + height)) &&

The second one is a copy-paste of the fist one, only it should have been referencing "child."

Revision history for this message
David Barksdale (david-barksdale) wrote :
Revision history for this message
Tomasz Sterna (smoku) wrote :

Fix merged and pushed to https://github.com/Cordia/libhildon
Thank you for your patch.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.