compute-hyperv

Leaked resources after cold migration

Bug #1705683 reported by Alexandru Muresan on 2017-07-21

This bug affects 1 person

	Status	Importance	Assigned to
OpenStack Compute (nova)	Fix Released	Medium	Alexandru Muresan
Pike	Fix Committed	Medium	Matt Riedemann
compute-hyperv	Fix Released	Undecided	Alexandru Muresan

Bug Description

At the moment, the vif ports are not unplugged after cold migration on the source node.

This affects ovs ports, which have to be unplugged by nova.

At the same time, attached volumes are not disconnected from the source node.

See original description

Tags:

Alexandru Muresan (amuresan) on 2017-07-21

tags:	added: hyper-v resize
Changed in compute-hyperv:
status:	New → In Progress
assignee:	nobody → Alexandru Muresan (amuresan)

Revision history for this message

Sylvain Bauza (sylvain-bauza) wrote on 2017-07-24:

Just setting the same assignee for all components.

Changed in nova:
status:	New → Confirmed
importance:	Undecided → Medium
assignee:	nobody → Alexandru Muresan (amuresan)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-04: Fix merged to compute-hyperv (master)

Reviewed: https://review.openstack.org/486113
Committed: https://git.openstack.org/cgit/openstack/compute-hyperv/commit/?id=2eabb86120237192aa4f7581fee3799a96f7d27e
Submitter: Jenkins
Branch: master

commit 2eabb86120237192aa4f7581fee3799a96f7d27e
Author: Alexandru Muresan <email address hidden>
Date: Fri Jul 21 13:24:29 2017 +0300

Ensure that vif ports are unplugged during cold migration

At the moment, the vif ports are not unplugged after cold migration
on the source node.

This change addresses this issue by passing the network info when
destroying the instance.

Change-Id: I902ab7499fa1aca7fab415393a9670350b8437aa
Closes-Bug: #1705683

Changed in compute-hyperv:
status:	In Progress → Fix Released

Lucian Petrut (petrutlucian94) on 2017-08-30

summary:	- vif ports are not unplugged after cold migration + Leaked resources after cold migration
description:	updated

OpenStack Infra (hudson-openstack) on 2017-08-30

Changed in nova:
assignee:	Alexandru Muresan (amuresan) → Lucian Petrut (petrutlucian94)
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-30: Fix proposed to compute-hyperv (master)

Fix proposed to branch: master
Review: https://review.openstack.org/499127

OpenStack Infra (hudson-openstack) on 2017-08-30

Changed in nova:
assignee:	Lucian Petrut (petrutlucian94) → Matt Riedemann (mriedem)

Matt Riedemann (mriedem) on 2017-08-30

Changed in nova:
assignee:	Matt Riedemann (mriedem) → Alexandru Muresan (amuresan)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-31: Fix merged to compute-hyperv (master)

Reviewed: https://review.openstack.org/499127
Committed: https://git.openstack.org/cgit/openstack/compute-hyperv/commit/?id=fedb492a1466ab0fdb9a055b4399f1876e19f291
Submitter: Jenkins
Branch: master

commit fedb492a1466ab0fdb9a055b4399f1876e19f291
Author: Lucian Petrut <email address hidden>
Date: Wed Aug 30 14:58:23 2017 +0300

Disconnect volumes after cold migrations

After cold migrating an instance, volumes are not disconnected on
the source node side. This change fixes it.

A recent change fixed a similar issue regarding vif ports but we've
missed volume connections.

Change-Id: I094b405a151366236d6b86e45e7a989818006e2b
Closes-Bug: #1705683

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-31: Fix proposed to compute-hyperv (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/499551

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-31: Fix merged to compute-hyperv (stable/pike)

Reviewed: https://review.openstack.org/499551
Committed: https://git.openstack.org/cgit/openstack/compute-hyperv/commit/?id=6887bbf70b134461011157b996a2014ff39923b5
Submitter: Jenkins
Branch: stable/pike

commit 6887bbf70b134461011157b996a2014ff39923b5
Author: Lucian Petrut <email address hidden>
Date: Wed Aug 30 14:58:23 2017 +0300

Disconnect volumes after cold migrations

After cold migrating an instance, volumes are not disconnected on
the source node side. This change fixes it.

A recent change fixed a similar issue regarding vif ports but we've
missed volume connections.

    Change-Id: I094b405a151366236d6b86e45e7a989818006e2b
    Closes-Bug: #1705683
    (cherry picked from commit fedb492a1466ab0fdb9a055b4399f1876e19f291)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-09-06: Fix merged to nova (master)

Reviewed: https://review.openstack.org/486955
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=20196b74dea4a1af4ea643a45fdb96b03f8ea96d
Submitter: Jenkins
Branch: master

commit 20196b74dea4a1af4ea643a45fdb96b03f8ea96d
Author: Alexandru Muresan <email address hidden>
Date: Tue Jul 25 12:18:27 2017 +0300

Hyper-V: Perform proper cleanup after cold migration

At the moment, vif ports and volume connections are not cleaned up
on the source node after a cold migration.

This change addresses this issue by passing the network and block
device info objects when destroying the instance.

Change-Id: I4fd61a6ac09f194ad8be61e6dda092bfd402b806
Closes-Bug: #1705683

Changed in nova:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-09-06: Fix proposed to nova (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/501254

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-09-15: Fix merged to nova (stable/pike)

Reviewed: https://review.openstack.org/501254
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=cd82d551a95b2fb7ae69c8234a4f9a250e015ac7
Submitter: Jenkins
Branch: stable/pike

commit cd82d551a95b2fb7ae69c8234a4f9a250e015ac7
Author: Alexandru Muresan <email address hidden>
Date: Tue Jul 25 12:18:27 2017 +0300

Hyper-V: Perform proper cleanup after cold migration

At the moment, vif ports and volume connections are not cleaned up
on the source node after a cold migration.

This change addresses this issue by passing the network and block
device info objects when destroying the instance.

    Change-Id: I4fd61a6ac09f194ad8be61e6dda092bfd402b806
    Closes-Bug: #1705683
    (cherry picked from commit 20196b74dea4a1af4ea643a45fdb96b03f8ea96d)