Compiz

Compiz ignores _MOTIF_WM_HINTS set from xprop

Bug #1702297 reported by Alberts Muktupāvels
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Compiz
Fix Released
Medium
Alberts Muktupāvels
compiz (Ubuntu)
Fix Released
Medium
Alberts Muktupāvels
Nominated for Xenial by Marco Trevisan (Treviño)
Xenial
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

Trying to remove and/or re-add window decorations using xprop does not work. Compiz expects that _MOTIF_WM_HINTS property type is _MOTIF_WM_HINTS while xprop use CARDINAL type.

[Test Case]

xprop -f _MOTIF_WM_HINTS 32c -set _MOTIF_WM_HINTS "0x2, 0x0, 0x0, 0x0, 0x0"

Use this command from terminal and then select window from which to remove decorations. Decorations should disappear from selected window.

To re-add decorations use this command:
xprop -f _MOTIF_WM_HINTS 32c -set _MOTIF_WM_HINTS "0x2, 0x0, 0x1, 0x0, 0x0"

[Regression Potential]

Metacity and Mutter also use AnyPropertyType when reading _MOTIF_WM_HINTS property so I guess there should be no regressions.

Related branches

lp://staging/~muktupavels/compiz/motif-wm-hints
Marco Trevisan (Treviño): Approve
Diff: 25 lines (+2/-2)
2 files modified
gtk/window-decorator/util.c (+1/-1)
src/screen.cpp (+1/-1)
lp://staging/~unity-team/compiz/x-sru5
Andrea Azzarone: Approve
Diff: 1777 lines (+936/-94)
31 files modified
VERSION (+1/-1)
debian/changelog (+28/-0)
debian/mate.ini (+9/-9)
debian/profile_upgrades/com.canonical.unity.unity-lowgfx.01.upgrade (+12/-0)
debian/unity-lowgfx.ini (+8/-2)
debian/unity.ini (+0/-1)
gtk/window-decorator/decorator.c (+2/-0)
gtk/window-decorator/metacity.c (+2/-0)
gtk/window-decorator/util.c (+1/-1)
include/core/abiversion.h (+1/-1)
include/core/atoms.h (+2/-0)
include/core/screen.h (+7/-1)
include/core/string.h (+3/-0)
plugins/grid/grid.xml.in (+10/-0)
plugins/grid/src/grid.cpp (+67/-22)
plugins/grid/src/grid.h (+0/-1)
plugins/move/move.xml.in (+58/-0)
plugins/move/src/move.cpp (+326/-2)
plugins/move/src/move.h (+16/-1)
plugins/neg/neg.xml.in (+5/-0)
plugins/neg/src/neg.cpp (+1/-1)
plugins/resize/resize.xml.in (+15/-0)
plugins/resize/src/logic/src/resize-logic.cpp (+8/-6)
plugins/resize/src/resize.cpp (+137/-37)
src/atoms.cpp (+4/-0)
src/event.cpp (+5/-0)
src/privatescreen.h (+6/-0)
src/privatescreen/tests/test-privatescreen.cpp (+2/-0)
src/screen.cpp (+137/-6)
src/string/src/string.cpp (+61/-0)
src/window.cpp (+2/-2)
Compiz Maintainers: Pending requested
Diff: 1684 lines (+1650/-0) (has conflicts)
3 files modified
debian/changelog (+93/-0)
gtk/window-decorator/decorator.c (+2/-0)
gtk/window-decorator/metacity.c.OTHER (+1555/-0)
lp://staging/~ci-train-bot/compiz/compiz-ubuntu-xenial-2841
Alberts Muktupāvels (muktupavels)
summary: - Compiz ignores _MOTIF_WM_HINTS
+ Compiz ignores _MOTIF_WM_HINTS set from xprop
Revision history for this message
kenn (whatnext) wrote :

I am waiting for that patch to have been merged but I think it's not been released yet.

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

It is merged and should be available in 17.10, but it is still not available / merged in 16.04...

Marco Trevisan (Treviño) (3v1n0)
Changed in compiz:
status: New → Fix Committed
Changed in compiz (Ubuntu):
status: New → Fix Released
no longer affects: compiz/xenial
Changed in compiz:
importance: Undecided → Medium
Changed in compiz (Ubuntu):
importance: Undecided → High
importance: High → Medium
Changed in compiz:
assignee: nobody → Alberts Muktupāvels (muktupavels)
Changed in compiz (Ubuntu):
assignee: nobody → Alberts Muktupāvels (muktupavels)
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Alberts, or anyone else affected,

Accepted compiz into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/compiz/1:0.9.12.3+16.04.20171116-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in compiz (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed verification-needed-xenial
Revision history for this message
John Lenton (chipaca) wrote :

Verified that 1:0.9.12.3+16.04.20171116-0ubuntu1 fixes the issue on xenial: before upgrading, I confirmed xprop didn't disable the decorations on an xterm window; after upgrading, it did.

Thank you!

Alberts Muktupāvels (muktupavels)
tags: added: verification-done verification-done-xenial
removed: verification-needed verification-needed-xenial
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package compiz - 1:0.9.12.3+16.04.20171116-0ubuntu1

---------------
compiz (1:0.9.12.3+16.04.20171116-0ubuntu1) xenial; urgency=medium

  [ Eleni Maria Stea ]
  * Added option to disable blend in grid plugin (LP: #1700859)
  * Move: add options for showing only the window shape (filled or not)
    (LP: #1700859)

  [ Alberts Muktupāvels ]
  * Ensure that surfaces used by metacity theme have device scale set to
    1 . (LP: #1530277) (LP: #1530277)
  * Use AnyPropertyType when getting _MOTIF_WM_HINTS property. (LP:
    #1702297)

  [ Martin Wimpress ]
  * mate: Avoid artefacts of Windows Thumbnail Previews (LP: #1606369)

  [ Marco Trevisan (Treviño) ]
  * move: damage all the border area in outline mode and ignore
    transparent colors (LP: #1700859)
  * grid: ignore alpha in colors when not blending, and fix animations
    (LP: #1700859)
  * resize: add support for disabling transparency and avoid over-
    damaging in outline mode (LP: #1700859)
  * Screen: add averageColor to get the current desktop average color
  * unity-lowgfx.ini: remove unsupported unity option

 -- Marco Trevisan (Treviño) <mail@3v1n0.net> Thu, 16 Nov 2017 23:00:54 +0000

Changed in compiz (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for compiz has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Compiz 0.9.14.0 was released today, which includes this fix.

Changed in compiz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.