Compiz

Windows cascading mode cause segfault

Bug #1302098 reported by Jing Wang on 2014-04-03

This bug affects 5 people

	Status	Importance	Assigned to	Milestone
Compiz	In Progress	High	Jing Wang	Compiz 0.9.12.2
0.9.11	Triaged	High	Unassigned	Compiz 0.9.11.3
compiz (Ubuntu)	Confirmed	Medium	Unassigned

Bug Description

I found a critical bug in compiz, the x-window-manager.

Ubuntu version : 12.04.4 LTS
compiz version : 1:0.9.7.12-0ubuntu3

The test case is as below.
1) Set the window placement option to cascade mode.
- run "gnome-terminal" and then type "sudo gconftool-2 --type int --set /apps/compiz-1/plugins/place/screen0/options/mode 0"
OR
- run "gconf-editor"(At first, install "gconf-editor" from software center) and then go through " /apps/compiz-1/plugins/place/screen0/options/" and the set "mode"value to 0

2) Run "gnome-terminal" and then repeat opening new windows about 30 times.(using shortcut key <Ctrl+Alt+T>)
(OR run "nautilus" file manager and then repeat opening new windows about 30 times (using shortcut key <Ctrl+N>))

It is Note for you: Although you reproduce this bug, your Ubuntu will not break. System restore is very simple. Please try log out and log in again. And then try resetting as following.
run "gnome-terminal" and then type "sudo gconftool-2 --type int --set /apps/compiz-1/plugins/place/screen0/options/mode 2"
(OR - run "gconf-editor"(At first, install "gconf-editor" from software center) and then go through " /apps/compiz-1/plugins/place/screen0/options/" and the set "mode"value to 2)

Tags:

Related branches

lp://staging/~compiz-team/compiz/lp-1302098

Jing Wang (prepangolin) on 2014-04-03

tags:

added: compiz-bug

Revision history for this message

Jing Wang (prepangolin) wrote on 2014-04-03:

When you run "dmesg", you can see segfault message.

Revision history for this message

manlonglive (manlonglive) wrote on 2014-04-07:

I found a bug in this type.
My working status is the following:

Ubuntu version : 12.04.4 LTS
compiz version : 1:0.9.7.12-0ubuntu3

I want to resolve this bug quickly now.

Regards.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-04-13:

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in compiz (Ubuntu):
status:	New → Confirmed

Daniel van Vugt (vanvugt) on 2014-05-13

Changed in compiz:
status:	New → Confirmed

Revision history for this message

Jing Wang (prepangolin) wrote on 2014-09-28:

It's on me.

Changed in compiz:
assignee:	nobody → Jing Wang (prepangolin)
status:	Confirmed → Fix Committed

Revision history for this message

Jing Wang (prepangolin) wrote on 2014-09-28:

cascade_mode_segfault.patch Edit (2.1 KiB, text/plain)

- Disable cascadeFindFirstFit
The cause of segfault, so reference to null pointer
std::sort （belowSorted.begin(), belowSorted.end(), compareTopmost）;
I got the log message using compLogMessage() function.
You can got the message in console, to do this, type #compiz --replace ccp

- Fixed to cascadeFindNext function
If we go off the screen, start over with a new cascade.
I fixed to error condition： cascadeY + winHeight > workArea.bottom()
There was an logical error on calculating of window position(x,y)
e.g. 465+434 > 900 in this case: error occured(no next to cascade)

In my opinion, First, cascadeFindFirstFit function was not completed, so useless
Second, my patch is tricky, so need to improve.
Good review for this patch would be welcome!

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2014-09-28:

The attachment "cascade_mode_segfault.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags:

added: patch

Stephen M. Webb (bregma) on 2014-09-30

Changed in compiz:
importance:	Undecided → Medium
Changed in compiz (Ubuntu):
importance:	Undecided → Medium

Christopher Townsend (townsend) on 2014-09-30

Changed in compiz:
status:	Fix Committed → In Progress

Revision history for this message

Jing Wang (prepangolin) wrote on 2014-10-17:

How to output the log to console?
- after changing any code of compiz, then make install
- It can be logged via CompLogMessage() function
- replace the new compiled libplace.so with /usr/lib/compiz/libplace.so
- In Terminal, type "$compiz --replace"
It will show messages