Compiz

Coverity MISSING_BREAK - CID 12468

Bug #1101430 reported by Product Strategy Coverity Bug Uploader on 2013-01-18

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Compiz	Fix Released	Medium	MC Return	Compiz 0.9.9.0
0.9.9	Fix Released	Medium	MC Return	Compiz 0.9.9.0
compiz (Ubuntu)	Fix Released	Medium	MC Return

Bug Description

This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
CID: 12468
Checker: MISSING_BREAK
Category: No category available
CWE definition: http://cwe.mitre.org/data/definitions/484.html
File: /tmp/buildd/compiz-0.9.9~daily13.01.14/src/session.cpp
Function: CompSession::getClientId(CompSession::ClientIdType)
Code snippet:
320 if (!connected)
321 return "";
322
323 switch (type) {
CID 12468 - MISSING_BREAK
This case (value 0) is not terminated by a 'break' statement.
324 case CompSession::ClientId:
325 if (smClientId)
326 return smClientId;
CID 12468 - MISSING_BREAK
The above case falls through to this one.
327 case CompSession::PrevClientId:
328 if (smPrevClientId)
329 return smPrevClientId;

Tags:

Related branches

lp://staging/~mc-return/compiz/compiz.merge-fix1101430-missing-break

Merged into lp://staging/compiz/0.9.9 at revision 3571

Daniel van Vugt: Approve on 2013-01-22

PS Jenkins bot: Pending (continuous-integration) requested 2013-01-22

lp://staging/ubuntu/raring/compiz

Revision history for this message

Product Strategy Coverity Bug Uploader (coverity-uploader) wrote on 2013-01-18: compiz-0.9.9: /tmp/buildd/compiz-0.9.9~daily13.01.14/src/session.cpp

compiz-0.9.9: /tmp/buildd/compiz-0.9.9~daily13.01.14/src/session.cpp Edit (63.1 KiB, text/html)

Source file with Coverity annotations.

Changed in compiz:
importance:	Undecided → High

Daniel van Vugt (vanvugt) on 2013-01-22

Changed in compiz (Ubuntu):
status:	New → In Progress
importance:	Undecided → Medium
assignee:	nobody → MC Return (mc-return)

PS Jenkins bot (ps-jenkins) on 2013-01-22

Changed in compiz:
status:	In Progress → Fix Committed

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2013-01-22:

Fix committed into lp:compiz at revision 3571, scheduled for release in Compiz 0.9.9.0

Changed in compiz (Ubuntu):
status:	In Progress → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-01-25:

This bug was fixed in the package compiz - 1:0.9.9~daily13.01.25-0ubuntu1

---------------
compiz (1:0.9.9~daily13.01.25-0ubuntu1) raring; urgency=low

  [ Didier Roche ]
  * Really take default patched hsize and vsize and don't override them
    to fix (LP: #868423)

  [ sampo555 ]
  * [regression] Window resize granularity is lost when restored after
    using Grid (LP: #925867)
  * Window management - Restoring a grid-placed window by dragging the
    title bar downwards does not restore the original window width (LP:
    #878516)

  [ Daniel van Vugt ]
  * Several memory leaks in
    google::protobuf::DescriptorPool::InternalAddGeneratedFile() from
    google::protobuf::protobuf_AddDesc_*() (LP: #1102829)
  * Several leaks in g_settings_new() [g_object_new()] from
    ccsGSettingsNewNoPath() [ccs_gsettings_interface_wrapper.c:184] (LP:
    #1097649)
  * Several memory leaks in g_signal_new() ... from
    ccsGSettingsWrapperNewForSchema()
    [ccs_gsettings_interface_wrapper.c:184] from initBackend()
    [gsettings.c:468] (LP: #1102822)

  [ Sam Spilsbury ]
  * Several memory leaks in strdup() from
    ccsGSettingsIntegratedSettingReadValue() from
    ccsGNOMEIntegrationBackendReadISAndSetSettingForType() from
    ccsGNOMEIntegrationBackendReadOptionIntoSetting() (LP: #1100564)

  [ MC Return ]
  * Coverity MISSING_BREAK - CID 12468 (LP: #1101430)
  * Coverity MISSING_BREAK - CID 12466 (LP: #1101558)
  * Coverity MISSING_BREAK - CID 12467 (LP: #1101465)
  * Showmouse plugin: Possible values of the particle life setting can
    destroy the plugin's functionality (LP: #1098877)
  * Coverity MISSING_BREAK - CID 12465 (LP: #1101557)

[ Automatic PS uploader ]
* Automatic snapshot from revision 3582
-- Automatic PS uploader <email address hidden> Fri, 25 Jan 2013 04:03:43 +0000