Compiz Core

Cleanup code - purge use of "::screen" global

Bug #931502 reported by Alan Griffiths
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
Triaged
Wishlist
Unassigned
Compiz Core
Triaged
Wishlist
Unassigned

Bug Description

Classes that need to refer to CompScreen should be provided a pointer via their constructor and keep it.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I thought about this too. However my experience with plugin code tells me that too many plugins need fixing. And that's a risky long-term task.

Changed in compiz-core:
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Agree it isn't short term. First step would be to put mechanisms in place and remove the use in compiz-core (without removing the global). That by itself removes some of the painful coupling that hinders the current drive to get code under test.

Once core is clean, the plugins can be updated and only then remove the global entirely.

Sam Spilsbury (smspillaz)
Changed in compiz:
importance: Undecided → Wishlist
status: New → Triaged
Stephen M. Webb (bregma)
tags: added: refactor-for-testability
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.