Comment 2 for bug 893998

Revision history for this message
Sam Spilsbury (smspillaz) wrote : Re: [Bug 893998] Re: Fix warnings in CompTimer

On Thu, Nov 24, 2011 at 10:42 AM, Daniel van Vugt <email address hidden> wrote:
> Maybe try adding this gcc option to prevent similar regressions:
>
> -Werror
>           Make all warnings into errors.
>

Urgh,

Unity uses -Werror and I really don't like it. I have to do a lot of
things during debugging that generate warnings (inline assembly,
printing window id's etc) and this just makes debugging painful. There
are also some header files that we include which generate warnings
because of misuse of #define and friends. Might be better to make it
so that any automated branch merging bot that we'll be deploying in
the future rejects code that generates warnings.

> --
> You received this bug notification because you are a member of Compiz
> Maintainers, which is the registrant for Compiz Core.
> https://bugs.launchpad.net/bugs/893998
>
> Title:
>  Fix warnings in CompTimer
>
> Status in Compiz Core:
>  In Progress
> Status in “compiz” package in Ubuntu:
>  In Progress
>
> Bug description:
>  CompTimer and related classes currently generate warnings
>  because the GLib timeout is a signed integer and that's being compared to an unsigned
>  timeDiff integer from the CompTimer class.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/compiz-core/+bug/893998/+subscriptions
>

--
Sam Spilsbury