Compiz Core

compiz crashes with SIGSEGV in startup: ./bin/compiz (core) - Fatal: Private index value "15CompositeScreen_index_5" already stored in screen.

Bug #1065815 reported by Daniel van Vugt
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
Fix Released
High
Daniel van Vugt
Compiz 0.9.9.0
0.9.8
Fix Released
High
Daniel van Vugt
Compiz 0.9.8.6 "SRU-1"
Compiz Core
Triaged
Undecided
Unassigned
Compiz Core 0.9.7.14 "SRU-3"
compiz (Ubuntu)
Fix Released
Undecided
Unassigned
Quantal
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

A crasher that may explain a class of compiz crashes regarding disabling and enabling plugins.

[Test case]

Compile compiz with clang and try to start it.

[Regression potential]

Low, adds only template lines and no real code.

---original description below---

Compiled compiz with clang (env CC=clang CXX=clang++) and it crashes on startup:

./bin/compiz (core) - Info: Loading plugin: core
./bin/compiz (core) - Info: Starting plugin: core
./bin/compiz (core) - Info: Loading plugin: composite
./bin/compiz (core) - Info: Starting plugin: composite
./bin/compiz (core) - Info: Loading plugin: opengl
./bin/compiz (core) - Info: Starting plugin: opengl
./bin/compiz (core) - Fatal: Private index value "15CompositeScreen_index_5" already stored in screen.
Segmentation fault (core dumped)

Core was generated by `./bin/compiz --replace composite opengl move resize decor'.
Program terminated with signal 11, Segmentation fault.
#0 CompositeScreen::output (this=<optimised out>)
    at /home/dan/bzr/compiz/trunk/plugins/composite/src/screen.cpp:627
627 return priv->output;
(gdb) bt
#0 CompositeScreen::output (this=<optimised out>)
    at /home/dan/bzr/compiz/trunk/plugins/composite/src/screen.cpp:627
#1 0x00007f5b0fde5441 in PrivateGLScreen::PrivateGLScreen (
    this=<optimised out>, gs=<optimised out>)
    at /home/dan/bzr/compiz/trunk/plugins/opengl/src/screen.cpp:1139
#2 0x00007f5b0fde453c in GLScreen::GLScreen (this=<optimised out>,
    s=<optimised out>)
    at /home/dan/bzr/compiz/trunk/plugins/opengl/src/screen.cpp:829
#3 0x00007f5b0fdd3f56 in PluginClassHandler<GLScreen, CompScreen, 6>::get (
    base=<error reading variable: Unhandled dwarf expression opcode 0x0>)
    at /home/dan/bzr/compiz/trunk/plugins/../src/pluginclasshandler/include/core/pluginclasshandler.h:225
#4 0x00007f5b0fde175c in CompPlugin::VTableForScreenAndWindow<GLScreen, GLWindow>::initScreen(CompScreen*) ()
   from /home/dan/trunk.clang/lib/compiz/libopengl.so
#5 0x00007f5b192ddd75 in CompManager::initPlugin (p=<optimised out>)
    at /home/dan/bzr/compiz/trunk/src/plugin.cpp:233
#6 0x00007f5b192de7cf in CompPlugin::push (p=<optimised out>)
    at /home/dan/bzr/compiz/trunk/src/plugin.cpp:449
#7 0x00007f5b192a82e0 in compiz::private_screen::PluginManager::updatePlugins
    (this=<error reading variable: Unhandled dwarf expression opcode 0x0>,
    screen=<optimised out>, extraPluginsRequested=...)
    at /home/dan/bzr/compiz/trunk/src/screen.cpp:1117
#8 0x00007f5b192b2f59 in initPlugins (this=<optimised out>,
    this=<optimised out>) at /home/dan/bzr/compiz/trunk/src/screen.cpp:4777
#9 CompScreenImpl::init (this=<optimised out>, name=<optimised out>)
    at /home/dan/bzr/compiz/trunk/src/screen.cpp:4820
#10 0x0000000000404425 in CompManager::init (this=0x7fffd8b3aa58)
    at /home/dan/bzr/compiz/trunk/src/main.cpp:168
#11 0x00000000004046f2 in main (argc=<optimised out>, argv=<optimised out>)
    at /home/dan/bzr/compiz/trunk/src/main.cpp:257
(gdb)

See original description

Related branches

lp://staging/~vanvugt/compiz/fix-1065815
Sam Spilsbury: Approve
jenkins (community): Approve (continuous-integration)
Diff: 293 lines (+54/-0)
18 files modified
plugins/animation/include/animation/screen.h (+4/-0)
plugins/animation/include/animation/window.h (+3/-0)
plugins/animation/src/animation.cpp (+4/-0)
plugins/composite/include/composite/composite.h (+4/-0)
plugins/composite/src/screen.cpp (+2/-0)
plugins/composite/src/window.cpp (+2/-0)
plugins/cube/include/cube/cube.h (+2/-0)
plugins/cube/src/cube.cpp (+4/-0)
plugins/cube/src/privates.h (+3/-0)
plugins/mousepoll/src/mousepoll.cpp (+2/-0)
plugins/mousepoll/src/private.h (+3/-0)
plugins/opengl/include/opengl/opengl.h (+3/-0)
plugins/opengl/src/screen.cpp (+2/-0)
plugins/opengl/src/window.cpp (+3/-0)
plugins/scale/include/scale/scale.h (+4/-0)
plugins/scale/src/scale.cpp (+4/-0)
plugins/text/src/private.h (+3/-0)
plugins/text/src/text.cpp (+2/-0)
lp://staging/compiz/0.9.8
lp://staging/~timo-jyrinki/ubuntu/quantal/compiz/ubuntu.0984bzr3411_superseded
lp://staging/~timo-jyrinki/ubuntu/quantal/compiz/ubuntu.0984bzr3412
lp://staging/ubuntu/raring/compiz
lp://staging/ubuntu/quantal-proposed/compiz
lp://staging/ubuntu/quantal-updates/compiz
Daniel van Vugt (vanvugt)
Changed in compiz:
milestone: none → 0.9.9.0
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

And valgrind says

==27820== Invalid read of size 8
==27820== at 0xA0D69B0: CompositeScreen::output() (screen.cpp:627)
==27820== by 0xA721430: PrivateGLScreen::PrivateGLScreen(GLScreen*) (screen.cpp:1139)
==27820== by 0xA72052B: GLScreen::GLScreen(CompScreen*) (screen.cpp:829)
==27820== by 0xA70FF45: PluginClassHandler<GLScreen, CompScreen, 6>::get(CompScreen*) (pluginclasshandler.h:225)
==27820== by 0xA71D74B: CompPlugin::VTableForScreenAndWindow<GLScreen, GLWindow>::initScreen(CompScreen*) (plugin.h:229)
==27820== by 0x4EB6D74: CompManager::initPlugin(CompPlugin*) (plugin.cpp:233)
==27820== by 0x4EB77CE: CompPlugin::push(CompPlugin*) (plugin.cpp:449)
==27820== by 0x4E812DF: compiz::private_screen::PluginManager::updatePlugins(CompScreen*, std::vector<CompOption::Value, std::allocator<CompOption::Value> > const&) (screen.cpp:1117)
==27820== by 0x4E8BF58: CompScreenImpl::init(char const*) (screen.cpp:4777)
==27820== by 0x404424: CompManager::init() (main.cpp:168)
==27820== by 0x4046F1: main (main.cpp:257)
==27820== Address 0x60 is not stack'd, malloc'd or (recently) free'd
==27820==
==27820==
==27820== Process terminating with default action of signal 11 (SIGSEGV): dumping core
==27820== Access not within mapped region at address 0x60
==27820== at 0xA0D69B0: CompositeScreen::output() (screen.cpp:627)
==27820== by 0xA721430: PrivateGLScreen::PrivateGLScreen(GLScreen*) (screen.cpp:1139)
==27820== by 0xA72052B: GLScreen::GLScreen(CompScreen*) (screen.cpp:829)
==27820== by 0xA70FF45: PluginClassHandler<GLScreen, CompScreen, 6>::get(CompScreen*) (pluginclasshandler.h:225)
==27820== by 0xA71D74B: CompPlugin::VTableForScreenAndWindow<GLScreen, GLWindow>::initScreen(CompScreen*) (plugin.h:229)
==27820== by 0x4EB6D74: CompManager::initPlugin(CompPlugin*) (plugin.cpp:233)
==27820== by 0x4EB77CE: CompPlugin::push(CompPlugin*) (plugin.cpp:449)
==27820== by 0x4E812DF: compiz::private_screen::PluginManager::updatePlugins(CompScreen*, std::vector<CompOption::Value, std::allocator<CompOption::Value> > const&) (screen.cpp:1117)
==27820== by 0x4E8BF58: CompScreenImpl::init(char const*) (screen.cpp:4777)
==27820== by 0x404424: CompManager::init() (main.cpp:168)
==27820== by 0x4046F1: main (main.cpp:257)

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Could be related to bug 1064602.

Changed in compiz:
assignee: nobody → Daniel van Vugt (vanvugt)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Alright, I have a fix that works. And I suspect it may fix some of those strange crashes in and around PluginClassHandler you see when toggling plugins in CCSM.

Changed in compiz:
status: New → In Progress
Omer Akram (om26er)
Changed in compiz:
importance: Undecided → High
jenkins (martin-mrazik+qa)
Changed in compiz:
status: In Progress → Fix Committed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fix committed into lp:compiz at revision 3415

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Set to High to 0.9.8 too.

Although the crash I reported only happens with clang, not gcc or Ubuntu builds, the fix quite possibly also solves crashes we do see in Ubuntu when plugins are toggled in CCSM.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fix committed to lp:compiz/0.9.8 at revision 3408, scheduled for release in Compiz 0.9.8.6.

Timo Jyrinki (timo-jyrinki)
description: updated
Timo Jyrinki (timo-jyrinki)
Changed in compiz (Ubuntu):
status: New → Confirmed
Timo Jyrinki (timo-jyrinki)
description: updated
Timo Jyrinki (timo-jyrinki)
Changed in compiz (Ubuntu):
status: Confirmed → In Progress
Changed in compiz (Ubuntu Quantal):
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package compiz - 1:0.9.8.4+bzr3412-0ubuntu1

---------------
compiz (1:0.9.8.4+bzr3412-0ubuntu1) raring; urgency=low

  * New upstream snapshot.
    - Avoid duplicate template instantiations of PluginClassHandler<>, at
      least for those plugins that get re-used by others. (LP: #1065815)
    - Don't try to dereference NULL, which is returned by
      ccsGConfIntegratedSettingReadValue when it gets unexpected data
      from gconf. (LP: #1056615)
    - Stop the resize border (Rectangle resize mode) from flickering
      slightly. (LP: #1068518)
 -- Timo Jyrinki <email address hidden> Fri, 09 Nov 2012 09:52:15 +0200

Changed in compiz (Ubuntu):
status: In Progress → Fix Released
Daniel van Vugt (vanvugt)
Changed in compiz-core:
status: New → Triaged
milestone: none → 0.9.7.12
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Daniel, or anyone else affected,

Accepted compiz into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/compiz/1:0.9.8.4+bzr3412-0ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in compiz (Ubuntu Quantal):
status: In Progress → Fix Committed
tags: added: verification-needed
Timo Jyrinki (timo-jyrinki)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Scott Kitterman (kitterman) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package compiz - 1:0.9.8.4+bzr3412-0ubuntu0.1

---------------
compiz (1:0.9.8.4+bzr3412-0ubuntu0.1) quantal-proposed; urgency=low

  * New upstream snapshot.
    - Avoid duplicate template instantiations of PluginClassHandler<>, at
      least for those plugins that get re-used by others. (LP: #1065815)
    - Don't try to dereference NULL, which is returned by
      ccsGConfIntegratedSettingReadValue when it gets unexpected data
      from gconf. (LP: #1056615)
    - Stop the resize border (Rectangle resize mode) from flickering
      slightly. (LP: #1068518)
 -- Timo Jyrinki <email address hidden> Fri, 09 Nov 2012 09:52:15 +0200

Changed in compiz (Ubuntu Quantal):
status: Fix Committed → Fix Released
Daniel van Vugt (vanvugt)
Changed in compiz-core:
milestone: 0.9.7.12 → 0.9.7.14
Daniel van Vugt (vanvugt)
Changed in compiz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.