Pressing date input button fast tries to add DatePickerDialog fragment twice

It seems some bug with the FragmentsManager or DialogFragment in the v4 support library. All you need to do is keep hammering the watch button to the right on the Meta tab.

Somehow, the previous fragment tapped away by clicking on the target of the button in the shadow is not always entirely gone( ft.remove()?) yet when another click on the button wants to add it (ft.add() or ft.replace()?).

I have tried code such as this and it seems to work better (or maybe my rhythm is off) but still fails (maybe needs to be inside some critical section (synchronized)?):

 public void onClick(View v) {...
               if (v.getId() == R.id.b_acquisition_date_change) {
   // Launch dialog to change acquisition date ....
   Fragment f = getActivity().getSupportFragmentManager().findFragmentByTag("acquisition_date_picker_dialog");
   if (f!=null){
    FragmentTransaction ft = getActivity().getSupportFragmentManager().beginTransaction()
               .remove(f);
    ft.commit();
   } else {
    mAcquisitionDatePickerDialogFragment.show(getActivity().getSupportFragmentManager(), "acquisition_date_picker_dialog");
   }
  }
 }

Could not find this bug online yet, and it is only really visible with the monkey.

I have also checked that I don't create a new DialogFragment each time and don't clean up the old one. Indeed, that is the case seemingly.

    @Override
 public void onLoadFinished(Loader<Cursor> loader, Cursor cursor) {
...
  if(mAcquisitionDatePickerDialogFragment != null && mAcquisitionDatePickerDialogFragment.getShowsDialog()) mAcquisitionDatePickerDialogFragment.dismissAllowingStateLoss();
  mAcquisitionDatePickerDialogFragment = new BookItemAcquisitionDatePickerDialog();
...
 }

I added the check before to dry and dismiss the old one first. However this immediately here gives another error:

12-19 18:25:39.198: E/AndroidRuntime(19524): java.lang.NullPointerException
12-19 18:25:39.198: E/AndroidRuntime(19524): at android.support.v4.app.DialogFragment.dismissInternal(DialogFragment.java:184)
12-19 18:25:39.198: E/AndroidRuntime(19524): at android.support.v4.app.DialogFragment.dismissAllowingStateLoss(DialogFragment.java:165)
12-19 18:25:39.198: E/AndroidRuntime(19524): at net.lp.collectionista.ui.fragments.items.book.TabbedBookItemEditFragment.onLoadFinished(TabbedBookItemEditFragment.java:418)

This should not be.

Seem to have fixed the main problem by adding this check in front:

if (!mAcquisitionDatePickerDialogFragment.isAdded()) mAcquisitionDatePickerDialogFragment.show(getActivity().getSupportFragmentManager(), "acquisition_date_picker_dialog");

Not cleaning up the old fragment in onLoadFinished is acceptable.

Not making the fix yet on occurrences of "Fragment.show(" where the fragment is a local variable. Tested in one place with searchAdd and its add dialog and couldn't reproduce there anyway.