Refactor set up code in tests to setUp methods
Bug #1714012 reported by
Emma Foley
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
collectd-ceilometer-plugin |
New
|
Wishlist
|
Unassigned |
Bug Description
* Task involves finding the common set-up code in unit tests and moving it to the setUp() functions.
* This helps keep the test code clean and and easy to grok
Examples of refactoring required:
* All tests in ``tests/
* ``tests/
** handler = CollectdLogHand
logger = logging.
logger.
** Refactor to ``self.logger`` in tests
** etc
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/500819 /git.openstack. org/cgit/ openstack/ collectd- ceilometer- plugin/ commit/ ?id=e4c64694295 7595a7ff12dff27 3582cf0b77f542
Committed: https:/
Submitter: Jenkins
Branch: master
commit e4c646942957595 a7ff12dff273582 cf0b77f542
Author: Emma Foley <email address hidden>
Date: Tue Sep 5 13:09:25 2017 +0000
[refactor] common/test_config: Remove duplicated config declaration in tests
* Added setUp() call
* Moved declaration of config to setUp()
* config -> self.config
Change-Id: I07a663552c5b63 33630f381961411 acd8ec39f73
Partial-Bug: #1714012