[SRU] Stable point releases for python-ovsdbapp

This is also valid for xena and yoga:

 python3-ovsdbapp | 1.12.0-0ubuntu1~cloud0 | xena | focal-updates | all
 python3-ovsdbapp | 1.12.0-0ubuntu1~cloud0 | xena-proposed | focal-proposed | all
 python3-ovsdbapp | 1.15.1-0ubuntu2~cloud0 | yoga | focal-updates | all
 python3-ovsdbapp | 1.15.1-0ubuntu2~cloud0 | yoga-proposed | focal-proposed | all

fixed is contained in 1.12.2 and 1.16.2, this needs to be in UCA

Marking the charm task as invalid - the package does get upgraded but it does not have the required fix for the underlying issue.

Note that the impacted deployment is using the OVN 22.03 Cloud Archive which pulls in OVS 2.17.3

Note that the 1.15.x series aligns with Yoga but has not had a new stable point release including this fix.

it is in a release now.

$ git tag --contains a69430a967bfa1096b9258a8445b617b9e122a22
1.15.3

Is there any update?

@Eric

> Is there any update?

Could you be a little more specific, please, in your question?

I think the question is about whether or not an SRU has been targeted to pick this up. The short answer is not yet.

Do we have plan to apply it into SRU? thanks!

New point releases for python-ovsdbapp have been uploaded to wallaby-staging, xena-staging, jammy unapproved, and zed-staging. Once this is accepted into jammy-proposed I will promote the other packages from <uca>-staging to <uca>-proposed.

> The following SRU process was followed:
> https://wiki.ubuntu.com/OpenStackUpdates

python-ovsdbapp is not a source package listed as part of that exception.

On Fri, Jul 7, 2023 at 4:25 PM Steve Langasek <email address hidden>
wrote:

> > The following SRU process was followed:
> > https://wiki.ubuntu.com/OpenStackUpdates
>
> python-ovsdbapp is not a source package listed as part of that
> exception.
>
>
Thanks for taking a look. I was hoping to provide the stable releases via
the microrelease SRU exception. Let me know what you think.

Corey

> --
> You received this bug notification because you are subscribed to the bug
> report.
> Matching subscriptions: openstack-charms
> https://bugs.launchpad.net/bugs/2007919
>
> Title:
> [SRU] Stable point releases for python-ovsdbapp
>
> Status in OpenStack Neutron API Charm:
> Invalid
> Status in Ubuntu Cloud Archive:
> Invalid
> Status in Ubuntu Cloud Archive wallaby series:
> Triaged
> Status in Ubuntu Cloud Archive xena series:
> Triaged
> Status in Ubuntu Cloud Archive yoga series:
> Triaged
> Status in Ubuntu Cloud Archive zed series:
> Triaged
> Status in python-ovsdbapp package in Ubuntu:
> Invalid
> Status in python-ovsdbapp source package in Jammy:
> Triaged
>
> Bug description:
> [Impact]
> This release sports mostly bug-fixes and we would like to make
> sure all of our supported customers have access to these
> improvements. The update contains the following package updates:
>
> python-ovsdbapp 2.1.1 (zed)
> python-ovsdbapp 1.15.3 (jammy/yoga)
> python-ovsdbapp 1.12.3 (xena)
> python-ovsdbapp 1.9.4 (wallaby)
>
> Delta between 2.1.0 and 2.1.1 (zed):
>
> - [97e738d] Fix TRY_AGAIN handling
> - [bbdc14a] Don't force_reconnect() on unhandled Idl exception
> - [c9e9473] Fix logging exception while handling transaction exception
> - [d90358c] Update TOX_CONSTRAINTS_FILE for stable/zed
> - [b58a340] Update .gitreview for stable/zed
>
> Delta between 1.15.1 and 1.15.3 (jammy/yoga):
>
> - [ab3e0cb] Don't force_reconnect() on unhandled Idl exception
> - [92cbba4] Fix logging exception while handling transaction exception
> - [315c809] Fix TRY_AGAIN handling
> - [a69430a] Handle OVS 2.17 change to Idl.tables
> - [de473ce] Fix broken behavior after recent OVS update
> - [10539ed] github no longer accepts git:// connections
> - [7735d5c] Update TOX_CONSTRAINTS_FILE for stable/yoga
> - [253afd4] Update .gitreview for stable/yoga
>
> Delta between 1.12.0 and 1.12.3 (xena):
>
> - [8202d53] Don't force_reconnect() on unhandled Idl exception
> - [1b04058] Fix logging exception while handling transaction exception
> - [fc62ae2] Fix TRY_AGAIN handling
> - [4d4402c] Update QoS register in "QoSAddCommand" if exists
> - [62ee947] Add cooperative_yield() to OvsdbIdl
> - [ab571f4] Handle OVS 2.17 change to Idl.tables
> - [a7a1d5c] Fix broken behavior after recent OVS update
> - [a73fbf1] github no longer accepts git:// connections
> - [3a0cd11] Log what exception caused abort of the transaction
> - [8c09568] Update TOX_CONSTRAINTS_FILE for stable/xena
> - [19a4364] Update .gitreview for stable/xena
> - [49ab130] tools: run functional tests against ovn/main branch
>
> Delta between 1.9.0 and 1.9.4 (wallaby):
>
> - [65d02f0] Don't force_reconnect()...

Hello Diko, or anyone else affected,

Accepted python-ovsdbapp into zed-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:zed-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-zed-needed to verification-zed-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-zed-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Diko, or anyone else affected,

Accepted python-ovsdbapp into xena-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:xena-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-xena-needed to verification-xena-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-xena-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Diko, or anyone else affected,

Accepted python-ovsdbapp into wallaby-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:wallaby-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-wallaby-needed to verification-wallaby-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-wallaby-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

> I would like to provide these new stable releases via microrelease SRU updates: https://wiki.ubuntu.com/StableReleaseUpdates#New_upstream_microreleases

Please provide the information specified at that link.

The autopkgtest doesn't look like it's running the test suite. Is it?

> The autopkgtest doesn't look like it's running the test suite. Is it?

It's also reporting neutral, rather than pass, probably as a consequence of the only test being marked "superficial". According to https://wiki.ubuntu.com/StableReleaseUpdates#New_upstream_microreleases, a dep8 test is a requirement. Please could you look in to this?

Thanks Robie. I've updated the [Test Case] section with more testing details.

Thanks.

I looked at the specific changes being made by upstream in this microrelease, and have some concerns. I found them broken down by commit here: https://opendev.org/openstack/ovsdbapp/commits/branch/stable/yoga

https://opendev.org/openstack/ovsdbapp/commit/ab3e0cb0d0865417efbf103f44954573a5ba92ac - this seems like a deliberate change in behaviour. But it doesn't come with any tests, and there's no explanation as to why it's needed in a stable release. Is this even a bugfix? What if the retrying behaviour *is* working for some user? Won't dropping that behaviour regress them?

https://opendev.org/openstack/ovsdbapp/commit/92cbba4481a7c7acedf24d8250fc7cf4be6b46d7 seems OK as a bugfix, but doesn't come with a test.

https://opendev.org/openstack/ovsdbapp/commit/315c8096c9bb3ad6d09e3b2f09bc1c128bc35497 seems good as a bugfix, and refers to bug 1988457 as what it is fixing, but doesn't come with a test.

https://opendev.org/openstack/ovsdbapp/commit/a69430a967bfa1096b9258a8445b617b9e122a22 doesn't come with a test.

https://opendev.org/openstack/ovsdbapp/commit/de473cea9defe04a6f904fa63a8cf49746534916 fixes a regression caused by a change in OVS, and does come with a test - great!

Conclusion

It doesn't seem like upstream microrelease updates come with enough testing to land them for Ubuntu users in stable releases without further manual testing. The upstream ab3e0cb commit is also concerning as it is a deliberate change in behaviour.

NACK for an Ubuntu SRU based on the upstream microrelease exception. Please justify and test each change you need individually instead.

An upload of python-ovsdbapp to jammy-proposed has been rejected from the upload queue for the following reason: "See https://bugs.launchpad.net/charm-neutron-api/+bug/2007919/comments/19".

Thanks for the review Robie. I appreciate your thorough reviews and keeping Ubuntu stable!

(Note: The following reply is taken from my reply to a related thread: https://lists.ubuntu.com/archives/ubuntu-release/2023-September/005765.html)

For the behavioral change [1], I think there is minimal regression potential as the change is limited to an exception path where sleeps and reconnects were determined to be unnecessary. I'd have appreciated it if they would have provided a bug reference for the commit to provide more context, however with that said, it seems they are making a code improvement here for performance reasons and they found it to be useful enough to backport to stable branches.
[1] https://opendev.org/openstack/ovsdbapp/commit/ab3e0cb0d0865417efbf103f44954573a5ba92ac

It is certainly not ideal to have missing unit tests. It's important to consider that we perform testing above and beyond the unit tests that are run as part of our package builds. The regression testing that we have in place for OpenStack is run for all stable releases. For that we deploy a full OpenStack cloud and then run tempest integration tests that exercise all of the packages and the cloud solution as a whole.

I think we have a solid history of limiting regression potential for OpenStack users in our stable releases and that remains very important to us.