Ubuntu Cloud Archive

[SRU] Some DNS extensions not working with OVN

Series ussuri
Bug #1947127

Bug #1947127 reported by Dr. Jens Harbott on 2021-10-14

This bug affects 5 people

	Status	Importance	Assigned to
Ubuntu Cloud Archive	Fix Released	Undecided	Unassigned
Ussuri	New	Undecided	Unassigned
Victoria	New	Undecided	Unassigned
Wallaby	Fix Released	Undecided	Unassigned
Xena	Fix Released	Undecided	Unassigned
Yoga	Fix Released	Undecided	Unassigned
neutron	Fix Released	High	Dr. Jens Harbott
neutron (Ubuntu)	Fix Released	Undecided	Unassigned
Impish	Fix Released	Undecided	Unassigned
Jammy	Fix Released	Undecided	Unassigned
Kinetic	Fix Released	Undecided	Unassigned

Bug Description

[Impact]

On a fresh devstack install with the q-dns service enable from the neutron devstack plugin, some features still don't work, e.g.:

$ openstack subnet set private-subnet --dns-publish-fixed-ip
BadRequestException: 400: Client Error for url: https://10.250.8.102:9696/v2.0/subnets/9f50c79e-6396-4c5b-be92-f64aa0f25beb, Unrecognized attribute(s) 'dns_publish_fixed_ip'

$ openstack port create p1 --network private --dns-name p1 --dns-domain a.b.
BadRequestException: 400: Client Error for url: https://10.250.8.102:9696/v2.0/ports, Unrecognized attribute(s) 'dns_domain'

The reason seems to be that https://review.opendev.org/c/openstack/neutron/+/686343/31/neutron/common/ovn/extensions.py only added dns_domain_keywords, but not e.g. dns_domain_ports as supported by OVN

[Test Case]

Create a normal OpenStack neutron test environment to see if we can successfully run the following commands:

openstack subnet set private_subnet --dns-publish-fixed-ip
openstack port create p1 --network private --dns-name p1 --dns-domain a.b.

[Regression Potential]

The fix has merged into the upstream stable/xena branch [1], here's just SRU into the 19.1.0 branch of UCA xena (the fix is already in 20.0.0 so it's already in jammy and kinetic and focal-yoga), so it is a clean backport and might be helpful for deployments migrating to OVN.

[1] https://review.opendev.org/c/openstack/neutron/+/838650

See original description

Tags:

Dr. Jens Harbott (j-harbott) on 2021-10-14

tags:

added: dns

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-10-14: Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/813969

Changed in neutron:
status:	New → In Progress

Dr. Jens Harbott (j-harbott) on 2021-10-14

Changed in neutron:
assignee:	nobody → Dr. Jens Harbott (j-harbott)

Lucas Alvares Gomes (lucasagomes) on 2021-10-15

Changed in neutron:
importance:	Undecided → High
tags:	added: ovn

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-10-15: Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/813969
Committed: https://opendev.org/openstack/neutron/commit/8a890ed29c681847d930bdf5403926c2e1450f9d
Submitter: "Zuul (22348)"
Branch: master

commit 8a890ed29c681847d930bdf5403926c2e1450f9d
Author: Dr. Jens Harbott <email address hidden>
Date: Thu Oct 14 11:19:41 2021 +0200

Fix list of DNS extensions supported by OVN

The OVN driver needs to announce all DNS extensions as supported,
otherwise the neutron server will reject them.

    Closes-Bug: 1947127
    Signed-off-by: Dr. Jens Harbott <email address hidden>
    Change-Id: Ic269902ef7a16893c4ea624b04347d04db4f52d9

Changed in neutron:
status:	In Progress → Fix Released

Bernard Cafarelli (bcafarel) on 2021-11-17

tags:

added: neutron-proactive-backport-potential

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-03-10: Fix included in openstack/neutron 20.0.0.0rc1

This issue was fixed in the openstack/neutron 20.0.0.0rc1 release candidate.

Thobias Trevisan (thobiastrevisan) on 2022-04-12

Changed in cloud-archive:
status:	New → Confirmed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-04-20: Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/838650

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-04-25: Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/838650
Committed: https://opendev.org/openstack/neutron/commit/8fe19f1ba45fdd4cabf80aa56825c9f007b2b11a
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 8fe19f1ba45fdd4cabf80aa56825c9f007b2b11a
Author: Dr. Jens Harbott <email address hidden>
Date: Thu Oct 14 11:19:41 2021 +0200

Fix list of DNS extensions supported by OVN

The OVN driver needs to announce all DNS extensions as supported,
otherwise the neutron server will reject them.

Conflicts:
neutron/common/ovn/extensions.py

NOTE(zhhuabj): The conflict is due to having change 666562a258c in stable/Xena.

    Closes-Bug: 1947127
    Signed-off-by: Dr. Jens Harbott <email address hidden>
    Change-Id: Ic269902ef7a16893c4ea624b04347d04db4f52d9
    (cherry picked from commit 8a890ed29c681847d930bdf5403926c2e1450f9d)
    Signed-off-by: Zhang Hua <email address hidden>

tags:

added: in-stable-xena

Hua Zhang (zhhuabj) on 2022-05-05

description:

updated

Revision history for this message

Hua Zhang (zhhuabj) wrote on 2022-05-05: Re: Some DNS extensions not working with OVN

focal-xena.debdiff Edit (13.6 KiB, text/plain)

summary:	- Some DNS extensions not working with OVN + [SRU] Some DNS extensions not working with OVN
Changed in cloud-archive:
status:	Confirmed → Fix Released

Revision history for this message

Hua Zhang (zhhuabj) wrote on 2022-05-05:

Can anyone add 'ubuntu cloud archive xena' project? It seems that I don't have permission to do it, thanks

tags:

added: sts sts-sru-needed

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2022-05-05:

The attachment "focal-xena.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags:

added: patch

Hua Zhang (zhhuabj) on 2022-05-11

description:

updated

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-05-25: Fix included in openstack/neutron 19.3.0

This issue was fixed in the openstack/neutron 19.3.0 release.

Revision history for this message

Edward Hope-Morley (hopem) wrote on 2022-05-30:

#10

this is releases in all but xena which will be available in the Ubuntu Cloud Archive in the upcoming 19.0.3 stable release

Changed in neutron (Ubuntu Jammy):
status:	New → Fix Released
Changed in neutron (Ubuntu Kinetic):
status:	New → Fix Released

Revision history for this message

Diko Parvanov (dparv) wrote on 2022-07-11:

#11

We are hitting this also on focal/ussuri with neutron 16.4.2-0ubuntu1 - is there supposed to be a backport for this?

Revision history for this message

Edward Hope-Morley (hopem) wrote on 2022-07-11:

#12

Added U/V/W for backport.

Changed in neutron (Ubuntu Impish):
status:	New → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-09-14: Fix proposed to neutron (stable/wallaby)

#13

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/857791

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-09-19: Fix merged to neutron (stable/wallaby)

#14

Reviewed: https://review.opendev.org/c/openstack/neutron/+/857791
Committed: https://opendev.org/openstack/neutron/commit/4c76a5349476110416d39121db9004b46d268a1d
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 4c76a5349476110416d39121db9004b46d268a1d
Author: Dr. Jens Harbott <email address hidden>
Date: Thu Oct 14 11:19:41 2021 +0200

Fix list of DNS extensions supported by OVN

The OVN driver needs to announce all DNS extensions as supported,
otherwise the neutron server will reject them.

    Conflicts:
            doc/source/admin/ovn/features.rst
            neutron/common/ovn/extensions.py

    Closes-Bug: 1947127
    Signed-off-by: Dr. Jens Harbott <email address hidden>
    Change-Id: Ic269902ef7a16893c4ea624b04347d04db4f52d9

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-11-02: Fix included in openstack/neutron 18.6.0

#15

This issue was fixed in the openstack/neutron 18.6.0 release.

Revision history for this message

Romain (romain-chanu) wrote on 2023-02-16:

#16

Hello,

I don't know if I should open a new bug but this bug affects ML2 plugin too.

$ openstack network set --dns-domain demo.domain.tld. 0f133524-ac0c-4444-bbb-9777ffec81ce

$ openstack subnet set --dns-publish-fixed-ip 4687aaad-4000-4f4d-aacc-46f8e9daaaa
BadRequestException: 400: Client Error for url: http:/cloud.domain.tld:9696/v2.0/subnets/4687aaad-4000-4f4d-aacc-46f8e9daaaa, Unrecognized attribute(s) 'dns_publish_fixed_ip'

# dpkg -l | grep neutron
ii neutron-common 2:19.4.0-0ubuntu1~cloud0 all Neutron is a virtual network service for Openstack - common

Distro: ubuntu:focal

I'm not aware about your priority but this feature is supposed to fix a bug from 2018. You will find below the previous launchpad:

https://bugs.launchpad.net/neutron/+bug/1784879

Best regards,
Romain