Click Update Manager

Autopilot tests using the ugly base class

Bug #1234379 reported by Corey Goldberg
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Click Update Manager
Fix Committed
High
Leo Arias
click-update-manager (Ubuntu)
Fix Released
Undecided
Unassigned
Saucy
Won't Fix
Undecided
Unassigned

Bug Description

insde lp:click-update-manager , there are set of Autopilot tests, which do not currently work.

specifically, `test_UI_is_loaded` test fails.

the issue seems to be:
inside `UbuntuTouchAppTestCase` (in tests/autopilot/click-update-manager/__init__.py), there is this:

@property
def main_window(self):
    return MainWindow(self.app)

`MainWindow` does not exist in the namespace, so this will always fail when called.

See original description

Related branches

lp://staging/~elopio/click-update-manager/fix1234379-autopilot_tests
Corey Goldberg (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diego Sarmentero (community): Approve
Ubuntu One hackers: Pending requested
Diff: 273 lines (+93/-135)
3 files modified
tests/autopilot/click_update_manager/__init__.py (+85/-117)
tests/autopilot/click_update_manager/main/__init__.py (+0/-1)
tests/autopilot/click_update_manager/test_main.py (+8/-17)
lp://staging/ubuntu/trusty-proposed/click-update-manager
Corey Goldberg (coreygoldberg)
description: updated
Roberto Alsina (ralsina)
Changed in click-update-manager:
assignee: nobody → Diego Sarmentero (diegosarmentero)
importance: Undecided → High
status: New → Triaged
Revision history for this message
Leo Arias (elopio) wrote :

I've checked the suite and no test uses the unimported MainWindow. However, this should be fixed, and cleaned. This test cases where copied from the qtcreator template, that's as ugly as it can be. Assigning to myself.

Changed in click-update-manager:
assignee: Diego Sarmentero (diegosarmentero) → Leo Arias (elopio)
summary: - Autopilot tests not working
+ Autopilot tests using the ugly base class
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:click-update-manager at revision 33, scheduled for release in click-update-manager, milestone Unknown

Changed in click-update-manager:
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package click-update-manager - 0.1+14.04.20140306-0ubuntu1

---------------
click-update-manager (0.1+14.04.20140306-0ubuntu1) trusty; urgency=low

  [ CI bot ]
  * No change rebuild against Qt 5.2.1.

  [ Diego Sarmentero ]
  * change modelChanged for updateAvailableFound. To run the tests you
    need to have the last branch of lp:clickmanager-plugin installed.
  * Show "Updates Not Found" not as title. (LP: #1232117)
  * Show app size in the proper way (BUG: #1232256). (LP: #1232256)
  * Fix desktop file to show icon in launcher. (LP: #1238835)

  [ Timo Jyrinki ]
  * Use xvfb -screen 0 640x480x24 for running tests. (LP: #1271172).
    (LP: #1271172)

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Leo Arias ]
  * Cleaned the autopilot test cases. (LP: #1234379)
 -- Ubuntu daily release <email address hidden> Thu, 06 Mar 2014 10:37:32 +0000

Changed in click-update-manager (Ubuntu):
status: New → Fix Released
Revision history for this message
Rolf Leggewie (r0lf) wrote :

saucy has seen the end of its life and is no longer receiving any updates. Marking the saucy task for this ticket as "Won't Fix".

Changed in click-update-manager (Ubuntu Saucy):
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.