Trying to build Cinder 21.0.0 (Zed) under Python 3.11 in Debian unstable results in 250 unit test failures the way I cut/past below.
This looks like a miss-use of the mock object that now fails. See the doc from upstream Python:
bpo-43478: Mocks can no longer be provided as the specs for other Mocks. As a result, an already-mocked object cannot be passed to mock.Mock(). This can uncover bugs in tests since these Mock-derived Mocks will always pass certain tests (e.g. isinstance) and builtin assert functions (e.g. assert_called_once_with) will unconditionally pass.
python/cpython#87644
https://docs.python.org/3.11/whatsnew/3.11.html
Please help me fix this so that Cinder can stay in Debian and be part of Debian 12 (Bookworm).
FAIL: cinder.tests.unit.volume.drivers.ceph.test_rbd_iscsi.RBDISCSITestCase.test_unsupported_version
cinder.tests.unit.volume.drivers.ceph.test_rbd_iscsi.RBDISCSITestCase.test_unsupported_version
----------------------------------------------------------------------
testtools.testresult.real._StringException: pythonlogging:'': {{{
2022-12-25 17:15:37,860 INFO [keystonemiddleware.auth_token] Starting Keystone auth_token middleware
2022-12-25 17:15:37,867 WARNING [keystonemiddleware._common.config] The option "auth_url" is not known to keystonemiddleware
2022-12-25 17:15:37,867 WARNING [keystonemiddleware.auth_token] AuthToken middleware is set with keystone_authtoken.service_token_roles_required set to False. This is backwards compatible but deprecated behaviour. Please set this to True.
2022-12-25 17:15:37,872 WARNING [keystonemiddleware.auth_token] Configuring www_authenticate_uri to point to the public identity endpoint is required; clients may not be able to authenticate against an admin endpoint
}}}
Traceback (most recent call last):
File "/usr/lib/python3.11/unittest/mock.py", line 1369, in patched
return func(*newargs, **newkeywargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/<<PKGBUILDDIR>>/cinder/tests/unit/volume/drivers/ceph/test_rbd_iscsi.py", line 167, in test_unsupported_version
self.setup_mock_client()
File "/usr/lib/python3.11/unittest/mock.py", line 1366, in patched
with self.decoration_helper(patched,
File "/usr/lib/python3.11/contextlib.py", line 137, in __enter__
return next(self.gen)
^^^^^^^^^^^^^^
File "/usr/lib/python3.11/unittest/mock.py", line 1348, in decoration_helper
arg = exit_stack.enter_context(patching)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/contextlib.py", line 502, in enter_context
result = _enter(cm)
^^^^^^^^^^
File "/usr/lib/python3.11/unittest/mock.py", line 1491, in __enter__
new = Klass(**_kwargs)
^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/unittest/mock.py", line 2100, in __init__
_safe_super(MagicMixin, self).__init__(*args, **kw)
File "/usr/lib/python3.11/unittest/mock.py", line 1100, in __init__
_safe_super(CallableMixin, self).__init__(
File "/usr/lib/python3.11/unittest/mock.py", line 451, in __init__
self._mock_add_spec(spec, spec_set, _spec_as_instance, _eat_self)
File "/usr/lib/python3.11/unittest/mock.py", line 502, in _mock_add_spec
raise InvalidSpecError(f'Cannot spec a Mock object. [object={spec!r}]')
unittest.mock.InvalidSpecError: Cannot spec a Mock object. [object=<MagicMock name='mock.client.RBDISCSIClient' id='140512319587344'>]
Hi Thomas Goirand, hope this message finds you well.
I'll bring this up on the cinder bug meeting. Would you mind sharing the full list of 250 unit test that are failing so i can reproduce in my env?
Thanks in advance,
Sofia