Cinder

RateLimitingMiddleware still belongs to v2 API code

Bug #1942696 reported by Takashi Kajinami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
In Progress
Medium
Takashi Kajinami

Bug Description

# This might not be the best place to discuss this but I hope this can initiate some discussion.

Currently RateLimitingMiddleware belongs to v2 API code, which is located under cinder.api.v2.
Ideally we should migrate this to v3 API code but there are some points we should consider before we determine to keep that middleware.

- The middleware is not included in the pre-defined pipelines in api-paste.ini .

- The middleware was ported from Nova but Nova has already dropped the middleware

- The middleware uses local memory to count API frequency. Which means it doesn't work properly in deployments with multiple nodes hosting cinder-api.

Considering these situations, it'd make more sense to deprecate/remove the middleware instead of keeping it under v3 API code.

See original description
Tags: api v2 v3
Takashi Kajinami (kajinamit)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/807469

Changed in cinder:
status: New → In Progress
Takashi Kajinami (kajinamit)
description: updated
Changed in cinder:
assignee: nobody → Takashi Kajinami (kajinamit)
Sofia Enriquez (lsofia-enriquez)
Changed in cinder:
importance: Undecided → High
Sofia Enriquez (lsofia-enriquez)
tags: added: api
tags: added: v2 v3
Sofia Enriquez (lsofia-enriquez)
Changed in cinder:
importance: High → Medium
Revision history for this message
Sofia Enriquez (lsofia-enriquez) wrote :

This bug is related to https://bugs.launchpad.net/cinder/+bug/1662637

Revision history for this message
Brian Rosmaita (brian-rosmaita) wrote :

As a comment on https://review.opendev.org/c/openstack/cinder/+/807469 indicates, some operators are still using this. So it looks like we do need to migrate it to the cinder.api.v3 module.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by "Takashi Kajinami <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/807469
Reason: The middleware is still used, thus can't be removed. We should migrate the code to v3 code base.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.