Cinder

backup/drivers/s3.py uses vendored requests from botocore

Bug #1921584 reported by Thomas Goirand
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
New
Low
Unassigned

Bug Description

Hi,

Building Cinder 18.0.0~rc1 in Debian leads to this:

  File "/<<PKGBUILDDIR>>/debian/tmp/usr/lib/python3/dist-packages/cinder/opts.py", line 41, in <module>
    from cinder.backup.drivers import s3 as cinder_backup_drivers_s3
  File "/<<PKGBUILDDIR>>/debian/tmp/usr/lib/python3/dist-packages/cinder/backup/drivers/s3.py", line 77, in <module>
    from botocore.vendored.requests.packages.urllib3 import exceptions as \
ModuleNotFoundError: No module named 'botocore.vendored'

In no way, Cinder should be using the vendored version of of requests/urllib3 in botocore (or elsewhere), as downstream distribution usually un-vendor things (to get a single, manageable copy of the library).

Please patch s3.py to directly use urllib3.

Cheers,

Thomas Goirand

Sofia Enriquez (lsofia-enriquez)
Changed in cinder:
importance: Undecided → Low
Revision history for this message
Eric Harney (eharney) wrote :

https://botocore.amazonaws.com/v1/documentation/api/latest/index.html#upgrading-to-1-11-0

indicates that the vendored requests lib is no longer used in botocore. We should update the Cinder code.

Revision history for this message
Sofia Enriquez (lsofia-enriquez) wrote :

We should also add some basic unittest to check if ModuleNotFoundError exception is being raised or not.

tags: added: aws backup-service drivers s3
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.