SADeprecationWarning: The joinedload_all() function is deprecated, and will be removed in a future release. Please use method chaining with joinedload() instead

Bug #1832164 reported by Takashi Natsume
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Committed
High
Gorka Eguileor
OpenStack Compute (nova)
Fix Released
Low
Takashi Natsume
Stein
Fix Committed
Low
sean mooney

Bug Description

The following warning is output in the unit tests.

    b'/tmp/nova/nova/db/sqlalchemy/api.py:1871: SADeprecationWarning: The joinedload_all() function is deprecated, and will be removed in a future release. Please use method chaining with joinedload() instead'
    b" options(joinedload_all('security_groups.rules')).\\"

* http://logs.openstack.org/53/566153/43/check/openstack-tox-py36/b7edf77/job-output.txt.gz

Tags: db testing
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.opendev.org/664193

Changed in nova:
status: New → In Progress
tags: added: db
Revision history for this message
Chris Dent (cdent) wrote :

This is causing failures in placement's gate when running the nova functional tests, because of subunit parser errors.

Changed in nova:
assignee: Takashi NATSUME (natsume-takashi) → Chris Dent (cdent)
Eric Fried (efried)
Changed in nova:
assignee: Chris Dent (cdent) → Takashi NATSUME (natsume-takashi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.opendev.org/664193
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=658e35cad4598113dd94fb4c685a06c7439b5a36
Submitter: Zuul
Branch: master

commit 658e35cad4598113dd94fb4c685a06c7439b5a36
Author: Takashi NATSUME <email address hidden>
Date: Mon Jun 10 13:07:15 2019 +0900

    Replace joinedload_all with joinedload

    Replace sqlalchemy.orm.joinedload_all with
    sqlalchemy.orm.joinedload called within a
    new method _joinedload_all that makes multiple
    calls to orm.joinedload.

    'joinedload_all' has been deprecated since
    sqlalchemy version 0.9.0, and now makes a
    lot of warning noises.

    Change-Id: I7a30efa8ceb21e02e71d8c15bf979bb66470ef91
    Closes-Bug: #1832164

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/671532

Matt Riedemann (mriedem)
Changed in nova:
importance: Undecided → Low
Revision history for this message
Matt Riedemann (mriedem) wrote :

sqlalchemy docs:

https://docs.sqlalchemy.org/en/13/changelog/migration_09.html#new-query-options-api-load-only-option

Added cinder since this also hits in cinder jobs in logstash.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/stein)

Reviewed: https://review.opendev.org/671532
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b12d16683637a0fd3ded1c02c6c4d69d7ca00aaa
Submitter: Zuul
Branch: stable/stein

commit b12d16683637a0fd3ded1c02c6c4d69d7ca00aaa
Author: Takashi NATSUME <email address hidden>
Date: Mon Jun 10 13:07:15 2019 +0900

    Replace joinedload_all with joinedload

    Replace sqlalchemy.orm.joinedload_all with
    sqlalchemy.orm.joinedload called within a
    new method _joinedload_all that makes multiple
    calls to orm.joinedload.

    'joinedload_all' has been deprecated since
    sqlalchemy version 0.9.0, and now makes a
    lot of warning noises.

    Change-Id: I7a30efa8ceb21e02e71d8c15bf979bb66470ef91
    Closes-Bug: #1832164
    (cherry picked from commit 658e35cad4598113dd94fb4c685a06c7439b5a36)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 19.0.2

This issue was fixed in the openstack/nova 19.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 20.0.0.0rc1

This issue was fixed in the openstack/nova 20.0.0.0rc1 release candidate.

Gorka Eguileor (gorka)
Changed in cinder:
assignee: nobody → Gorka Eguileor (gorka)
Revision history for this message
Gorka Eguileor (gorka) wrote :

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/780755

Changed in cinder:
status: New → In Progress
importance: Undecided → Critical
milestone: none → wallaby-rc1
Changed in cinder:
importance: Critical → High
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 18.0.0.0rc1

This issue was fixed in the openstack/cinder 18.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.