Replication 1.0 was not properly deprecated, no release notes for removal

Bug #1619649 reported by Scott DAngelo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Won't Fix
Undecided
Michal Dulko

Bug Description

The code for replication 1.0 was removed with the patch for Replication 2.1 (cheesecake):
https://review.openstack.org/#/c/275797/35

So the APIs for os-promote-replica and os-reenable-replica are gone, but were never deprecated (I dont' think).

We should likely have something in the release notes for this.

Changed in cinder:
milestone: none → next
Revision history for this message
Sean McGinnis (sean-mcginnis) wrote :

This happened in Mitaka after a lot of discussion with the only implementer of replication v1 support. It was decided since there were a limited number of users and it would make things more difficult and confusing to be able to implement replication v2.

Right or wrong, that's the history on it.

Revision history for this message
Scott DAngelo (scott-dangelo) wrote :

That's fine. I'm just wondering if we should have any documentation or releasenote for the fact that the apis are removed?
It came up during review of this:
https://review.openstack.org/364680

If we don't want to document, I'm OK with that. I just wanted to bring it up and see if there's something that should be done.

Changed in cinder:
assignee: nobody → Michal Dulko (michal-dulko-f)
status: New → In Progress
Revision history for this message
Michal Dulko (michal-dulko-f) wrote :

I've added a release note on that in Newton's release notes with the dead code removal patch [1]. Is it worth adding it to stable/mitaka?

[1] https://review.openstack.org/#/c/365620/

Revision history for this message
Michal Dulko (michal-dulko-f) wrote :

Based on Sean's comment in https://review.openstack.org/#/c/365620/.

Changed in cinder:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.