Cinder

manage_existing flow has poor unit test coverage

Bug #1599140 reported by Michal Dulko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
In Progress
Wishlist
Unassigned

Bug Description

We're almost missing unit tests for manage_existing functionality. The cinder.volume.flows.manager.manage_existing module has only ~37% of coverage, manage_existing_snapshot 61%. cinder.volume.flows.api.manage_existing also has ~58%.

These functionalities are often broken as they also aren't tested in Tempest yet. Therefore unit tests exercising these calls from manager down to the driver will be highly beneficial. An example of such test is cinder.tests.unit.test_volume.VolumeTestCase.test_create_delete_volume.

Eric Harney (eharney)
tags: added: tests
Yuriy Nesenenko (ynesenenko)
Changed in cinder:
assignee: nobody → Yuriy Nesenenko (ynesenenko)
Yuriy Nesenenko (ynesenenko)
Changed in cinder:
assignee: Yuriy Nesenenko (ynesenenko) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/353095

Changed in cinder:
assignee: nobody → John Planow (johnplanow)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/353095
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
Sean McGinnis (sean-mcginnis) wrote : Bug Assignee Expired

Unassigning due to no activity for > 6 months.

Changed in cinder:
assignee: John Planow (johnplanow) → nobody
status: In Progress → New
Sofia Enriquez (lsofia-enriquez)
Changed in cinder:
assignee: nobody → Sofia Enriquez (lsofia-enriquez)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/512796

Changed in cinder:
status: New → In Progress
OpenStack Infra (hudson-openstack)
Changed in cinder:
assignee: Sofia Enriquez (lsofia-enriquez) → Sean McGinnis (sean-mcginnis)
OpenStack Infra (hudson-openstack)
Changed in cinder:
assignee: Sean McGinnis (sean-mcginnis) → Sofia Enriquez (lsofia-enriquez)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/512796
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=0af13cb6a71a25ee6950f0b7307c0c6e1a4dad33
Submitter: Zuul
Branch: master

commit 0af13cb6a71a25ee6950f0b7307c0c6e1a4dad33
Author: Sofia Enriquez <email address hidden>
Date: Tue Oct 17 18:49:14 2017 +0000

    Add test coverage to manage existing flow

    We're almost missing unit tests for manage_existing functionality. The
    cinder.volume.flows.manager.manage_existing module has only ~37% of
    coverage, manage_existing_snapshot 61%.
    cinder.volume.flows.api.manage_existing also has ~58%.

    Change-Id: I28c1d70e5a53d7420e3eb52573d1d6fff474b635
    Partial-Bug: #1599140

Sofia Enriquez (lsofia-enriquez)
Changed in cinder:
assignee: Sofia Enriquez (lsofia-enriquez) → nobody
Sofia Enriquez (lsofia-enriquez)
tags: added: test-coverage
OpenStack Infra (hudson-openstack)
Changed in cinder:
assignee: nobody → Anastasiya Zhyrkevich (anastzhyr)
OpenStack Infra (hudson-openstack)
Changed in cinder:
assignee: Anastasiya Zhyrkevich (anastzhyr) → Sofia Enriquez (lsofia-enriquez)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/691527
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=19288b610dfa3c1c6309b0fcf05039eb44d6a357
Submitter: Zuul
Branch: master

commit 19288b610dfa3c1c6309b0fcf05039eb44d6a357
Author: anastasiya-zhyrkevich <email address hidden>
Date: Sun Oct 27 23:20:11 2019 +0300

    Add test coverage for manage_existing API revert

    New tests covers revert functionality for manage_existing API.
    Tests added
    1. revert ManageCastTask with volume status update check after rollback
    2. revert EntryCreateTask with check DB entry is destroyed
    3. revert EntryCreateTask with taskflow.Failure, no revert is expected

    Partial-Bug:#1599140
    Change-Id: I99df840bd7c8cd913d6045dd90871eb8894bbac8

Sofia Enriquez (lsofia-enriquez)
Changed in cinder:
assignee: Sofia Enriquez (lsofia-enriquez) → nobody
Sofia Enriquez (lsofia-enriquez)
Changed in cinder:
importance: Undecided → Wishlist
Revision history for this message
Benjamin Faruna (benfaruna) wrote :

Hello, I am an Outreachy intern. I would love to work on this.
Can I be assigned to this?

Revision history for this message
Ajay Pal (ajoo7) wrote :

Hi Sofia,
Can I also work on this bug, As I have resolved all issues of the last assigned bug?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.