start-builds and update-outcome are vulnerable to out-of-disk
Bug #1617408 reported by
Aaron Bentley
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
CI Director |
Fix Released
|
High
|
Aaron Bentley |
Bug Description
If there is nearly no disk space free, start-builds and update-outcome will write partial json files. Partial json files are invalid. These invalid json files typically replace existing, valid json files.
One solution would be to use atomic writes, where the file is written first, then renamed into place on completion. This would prevent invalid files from being written.
Related branches
lp://staging/~abentley/ci-director/atomic-file
- Curtis Hovey (community): Approve (code)
-
Diff: 111 lines (+62/-2)3 files modifiedcidirector/tests/test_utility.py (+38/-0)
cidirector/update_outcome.py (+2/-1)
cidirector/utility.py (+22/-1)
Changed in ci-director: | |
assignee: | nobody → Aaron Bentley (abentley) |
status: | Triaged → In Progress |
Changed in ci-director: | |
status: | In Progress → Fix Released |
To post a comment you must log in.