Chromium still tries to enable NEON on arm* builds when told not to

Bug #1084852 reported by Micah Gersten
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Chromium Browser
Unknown
Unknown
chromium-browser (Ubuntu)
Fix Released
High
Chad Miller
Oneiric
Won't Fix
Medium
Unassigned
Precise
Fix Released
Medium
Unassigned
Quantal
Fix Released
Medium
Unassigned

Bug Description

When passing 'arm_float_abi=hard arm_thumb=1 arm_neon=0 arm_fpu=vfpv3-d16 target_arch=arm', Chromium still tries to build with NEON:
/usr/lib/gcc/arm-linux-gnueabihf/4.7/include/arm_neon.h:32:2: error: #error You must enable NEON instructions (e.g. -mfloat-abi=softfp -mfpu=neon) to use arm_neon.h
third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/filters_neon.c: In function 'WebRtcIsacfix_AutocorrNeon':
third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/filters_neon.c:44:3: error: unknown type name 'int16x4_t'
third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/filters_neon.c:45:3: error: unknown type name 'int64x1_t'
third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/filters_neon.c:46:3: error: unknown type name 'int64x1_t'
third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/filters_neon.c:47:3: error: unknown type name 'int32x4_t'
third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/filters_neon.c:48:3: error: unknown type name 'int64x2_t'
third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/filters_neon.c:48:3: warning: implicit declaration of function 'vdupq_n_s64' [-Wimplicit-function-declaration]
third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/filters_neon.c:53:5: warning: implicit declaration of function 'vld1_s16' [-Wimplicit-function-declaration]
third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/filters_neon.c:54:5: warning: implicit declaration of function 'vmull_s16' [-Wimplicit-function-declaration]
third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/filters_neon.c:55:5: warning: implicit declaration of function 'vpadalq_s32' [-Wimplicit-function-declaration]
third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/filters_neon.c:57:3: warning: implicit declaration of function 'vget_low_s64' [-Wimplicit-function-declaration]
third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/filters_neon.c:58:3: warning: implicit declaration of function 'vget_high_s64' [-Wimplicit-function-declaration]
third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/filters_neon.c:59:3: warning: implicit declaration of function 'vadd_s64' [-Wimplicit-function-declaration]
third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/filters_neon.c:76:3: warning: implicit declaration of function 'vshl_s64' [-Wimplicit-function-declaration]
third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/filters_neon.c:79:3: warning: implicit declaration of function 'vget_lane_s64' [-Wimplicit-function-declaration]
make[1]: *** [out/Release/obj.target/isac_neon/third_party/webrtc/modules/audio_coding/codecs/isac/fix/source/filters_neon.o] Error 1
make[1]: *** Waiting for unfinished jobs....

Full log:
https://launchpadlibrarian.net/124450518/buildlog_ubuntu-raring-armhf.chromium-browser_23.0.1271.91-0ubuntu1_FAILEDTOBUILD.txt.gz

http://code.google.com/p/chromium/wiki/LinuxChromiumArm might have information to help (thanks infinity)

Tags: ftbfs
Micah Gersten (micahg)
description: updated
Revision history for this message
Gouchi (gouchi) wrote :

Please check :
https://code.google.com/p/chromium/issues/detail?id=154107

Thanks to #chromium for the information.

Micah Gersten (micahg)
Changed in chromium-browser (Ubuntu Oneiric):
importance: Undecided → Medium
status: New → Triaged
Changed in chromium-browser (Ubuntu Precise):
importance: Undecided → Medium
status: New → Triaged
Changed in chromium-browser (Ubuntu Quantal):
importance: Undecided → Medium
status: New → Triaged
Chad Miller (cmiller)
Changed in chromium-browser (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (7.7 KiB)

This bug was fixed in the package chromium-browser - 23.0.1271.97-0ubuntu0.12.04.1

---------------
chromium-browser (23.0.1271.97-0ubuntu0.12.04.1) precise-security; urgency=low

  * Omit resources/extension/demo files from any packaging verification
    because they're unwanted.
  * Update README.source to include some of these changes.
  * Drop "lzma" from build dependencies.
  * Make most patches follow a common format (no timestamps), to avoid
    future churn.
  * debian/patches/chromium_useragent.patch.in renamed to drop ".in",
    OS "Ubuntu" hardcoded with no compilation-release name, and patch
    refreshed to follow new location of source.
  * In debian/rules, use "-delete" flag on find instead of "-exec rm {} \;",
    to be safer and faster.
  * Also don't include python bytecode or cache files in orig tarball,
    and clean then up on "clean" rule.
  * Write the "REMOVED" list files to the root of the orig tarball,
    instead of inside the src/ directory, where they could collide.
  * Fix dpkg-source warning: Clean up python cached bytecode files.
  * Fix dpkg-source warning: Remove autoconf cache.
  * Fix lintian warning: fta and micahg to XSBC-Original-Maintainer.
  * Fix lintian error not-binnmuable-all-depends-any.
  * Override lintian complaints ancient-autotools-helper-file and
    unused-build-dependency-on-cdbs.
  * debian/patches/arm-neon.patch added to get ARM w/o Neon support.
    (LP: #1084852)
  * In debian/rules, avoid creating invalid subst expression in sed
    of DEBIAN* vars into files.
  * Remove unnecessary glib-header-single-entry.patch .
  * Add patches/struct-siginfo.patch to work around source bug in dereferencing
    internal stuct instead of public type.
  * New upstream version 23.0.1271.97
    - CVE-2012-5139: Use-after-free with visibility events.
    - CVE-2012-5140: Use-after-free in URL loader.
    - CVE-2012-5141: Limit Chromoting client plug-in instantiation.
    - CVE-2012-5142: Crash in history navigation.
    - CVE-2012-5143: Integer overflow in PPAPI image buffers.
    - CVE-2012-5144: Stack corruption in AAC decoding.

chromium-browser (23.0.1271.95-0ubuntu0.12.04.1) UNRELEASED; urgency=low

  [ Micah Gersten <email address hidden> ]
  * New upstream version 23.0.1271.95 (LP: #1086613)
    - CVE-2012-5138: Incorrect file path handling.
    - CVE-2012-5137: Use-after-free in media source handling.
  * Hardcode Ubuntu in Chromium user agent patch; Drop release specific part
    similar to what was done with Firefox; Drop from subst_files in rules
    - rename debian/patches/chromium_useragent.patch.in => debian/patches/chromium_useragent.patch
    - update debian/patches/chromium_useragent.patch
    - update debian/rules
  * Disable user agent patch for the moment as it doesn't apply cleanly
    - update debian/patches/series
  * Switch to xz binary packages, use Pre-Depends on dpkg (>= 1.15.6~)
    - update debian/control
  * Drop armhf FTBFS patch as it's been superseded by upstream changes
    - drop debian/patches/fix-armhf-ftbfs.patch
    - update debian/patches/series

  [ Chad Miller <email address hidden> ]
  * Add localization support for ast, bs, en-AU, eo, hy, ia, ka, ku, kw, ms....

Read more...

Changed in chromium-browser (Ubuntu Precise):
status: Triaged → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (9.7 KiB)

This bug was fixed in the package chromium-browser - 23.0.1271.97-0ubuntu0.10.04.1

---------------
chromium-browser (23.0.1271.97-0ubuntu0.10.04.1) lucid-security; urgency=low

  * Omit resources/extension/demo files from any packaging verification
    because they're unwanted.
  * Update README.source to include some of these changes.
  * Make most patches follow a common format (no timestamps), to avoid
    future churn.
  * debian/patches/chromium_useragent.patch.in renamed to drop ".in",
    OS "Ubuntu" hardcoded with no compilation-release name, and patch
    refreshed to follow new location of source.
  * In debian/rules, use "-delete" flag on find instead of "-exec rm {} \;",
    to be safer and faster.
  * Put REMOVED files in parent of "src", to be more certain of avoiding
    name collisions.
  * Also don't include python bytecode or cache files in orig tarball,
    and clean then up on "clean" rule.
  * Fix dpkg-source warning: Clean up python cached bytecode files.
  * Fix dpkg-source warning: Remove autoconf cache.
  * Override lintian complaints ancient-autotools-helper-file and
    unused-build-dependency-on-cdbs.
  * debian/patches/arm-neon.patch added to get ARM w/o Neon support.
    (LP: #1084852)
  * In debian/rules, avoid creating invalid subst expression in sed
    of DEBIAN* vars into files.
  * Remove unnecessary glib-header-single-entry.patch .
  * Add patches/struct-siginfo.patch to work around source bug in dereferencing
    internal stuct instead of public type.
  * New upstream version 23.0.1271.97
    - CVE-2012-5139: Use-after-free with visibility events.
    - CVE-2012-5140: Use-after-free in URL loader.
    - CVE-2012-5141: Limit Chromoting client plug-in instantiation.
    - CVE-2012-5142: Crash in history navigation.
    - CVE-2012-5143: Integer overflow in PPAPI image buffers.
    - CVE-2012-5144: Stack corruption in AAC decoding.

chromium-browser (23.0.1271.95-0ubuntu0.10.04.1) lucid-security; urgency=low

  [ Micah Gersten <email address hidden> ]
  * New upstream version 23.0.1271.95 (LP: #1086613)
    - CVE-2012-5138: Incorrect file path handling.
    - CVE-2012-5137: Use-after-free in media source handling.
  * Hardcode Ubuntu in Chromium user agent patch; Drop release specific part
    similar to what was done with Firefox; Drop from subst_files in rules
    - rename debian/patches/chromium_useragent.patch.in => debian/patches/chromium_useragent.patch
    - update debian/patches/chromium_useragent.patch
    - update debian/rules
  * Disable user agent patch for the moment as it doesn't apply cleanly
    - update debian/patches/series
  * Drop Pre-Depends: lzma since we switched to bzip2 binary compression
    - update debian/control

  [ Chad Miller <email address hidden> ]
  * Add localization support for ast, bs, en-AU, eo, hy, ia, ka, ku, kw, ms.
  * No longer include Launchpad-generated translations.
  * No longer expect unpacked tarball to contain "build-tree".
  * Fix build warning about missing debian/source/format. Set to "3.0
    (quilt)".
  * Make system-v8 patch use "type none" instead of "type settings".; Leave
    Patch disabled
  * Manually set DEB_{BUILD,HOST}_ARCH when not already ...

Read more...

Changed in chromium-browser (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (4.8 KiB)

This bug was fixed in the package chromium-browser - 23.0.1271.97-0ubuntu0.12.10.1

---------------
chromium-browser (23.0.1271.97-0ubuntu0.12.10.1) quantal-security; urgency=low

  * Omit resources/extension/demo files from any packaging verification
    because they're unwanted.
  * debian/chromium-driver.install: install chromedriver
  * Update README.source to include some of these changes.
  * Set new URL for channel-release info in rules file.
  * debian/patches/chromium_useragent.patch.in renamed to drop ".in",
    OS "Ubuntu" hardcoded with no compilation-release name, and patch
    refreshed to follow new location of source. Also remove it
    from the list of ephemeral files that "clean" rule removes.
  * In debian/rules, use "-delete" flag on find instead of "-exec rm {} \;",
    to be safer and faster.
  * Make most patches follow a common format (no timestamps or Index lines), to
    avoid future churn.
  * Write the "REMOVED" list files to the root of the orig tarball,
    instead of inside the src/ directory, where they could collide.
  * Fix dpkg-source warning: Clean up python cached bytecode files.
  * Also don't include python bytecode or cache files in orig tarball,
    and clean then up on "clean" rule.
  * Fix dpkg-source warning: Remove autoconf cache.
  * Fix lintian warning: fta and micahg to XSBC-Original-Maintainer.
  * Fix lintian error not-binnmuable-all-depends-any.
  * Override lintian complaints ancient-autotools-helper-file and
    unused-build-dependency-on-cdbs.
  * Drop "lzma" from build dependencies.
  * Set default binary and source package compression to xz. If
    building for Ubuntu 10.04, then make binary's compression to bzip2.
  * List explicit architectures that Chromium supports, instead of "any".
    Cr {arm ia32 x64} map into Debian {armhf armel i386 amd64}.
  * debian/patches/arm-neon.patch added to get ARM w/o Neon support.
    (LP: #1084852)
  * In debian/rules, avoid creating invalid subst expression in sed
    of DEBIAN* vars into files.
  * Note localization in package description for support for ast, bs, en-AU,
    eo, hy, ia, ka, ku, kw, ms.
  * No longer include Launchpad-generated translations. Disable patch
    grd_parse_fix.patch .
  * Set default binary and source package compression to xz. If
    building for Ubuntu 10.04, then make binary's compression to bzip2.
  * No longer expect unpacked tarball to contain "build-tree".
  * Fix build warning about missing debian/source/format. Set to "3.0
    (quilt)".
  * Remove unnecessary glib-header-single-entry.patch .
  * Manually set DEB_{BUILD,HOST}_ARCH when not already set, like when the
    executing program is not dpkg-buildpackage.
  * Make rules file generate LASTCHANGE file at new location.
  * Change get-sources command to kill script when it fails to disable
    gyp-chromium run from DEPS. Never fail silently again.
  * Add patches/struct-siginfo.patch to work around source bug in dereferencing
    internal stuct instead of public type.
  * Refresh patches from lp:unity-chromium-extension .
  * Make all patches follow a common format, to avoid future churn.
    No timestamps, a/b parent, sorted, no index.
  * New upstream v...

Read more...

Changed in chromium-browser (Ubuntu Quantal):
status: Triaged → Fix Released
Revision history for this message
Rolf Leggewie (r0lf) wrote :

oneiric has seen the end of its life and is no longer receiving any updates. Marking the oneiric task for this ticket as "Won't Fix".

Changed in chromium-browser (Ubuntu Oneiric):
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.