pcmcia-pcix/detect is not a detect test
Bug #866079 reported by
Ara Pulido
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox |
Fix Released
|
Medium
|
Jeff Lane |
Bug Description
The "detect" tests in checkbox should be only those that fail if the hardware is not present.
If we cannot determine correctly the PCMCIA hardware we should split this test in two:
* One detect to ask the user if their system contains or not PCMCIA
* Another one to actually run the test (depending on detect)
Related branches
lp://staging/~bladernr/checkbox/866079-pcmcia-test-changes
- Marc Tardif (community): Approve
- Jeff Lane : Needs Resubmitting
- Zygmunt Krynicki (community): Needs Fixing
-
Diff: 125 lines (+26/-13)7 files modifieddata/whitelists/default.whitelist (+2/-2)
debian/changelog (+14/-2)
jobs/expresscard.txt.in (+4/-3)
jobs/local.txt.in (+3/-3)
po/POTFILES.in (+1/-1)
qt/frontend/qtfront.cpp (+1/-1)
setup.cfg (+1/-1)
lp://staging/~bladernr/checkbox-certification/866079-pcmcia-whitelist-fix
- Checkbox Developers: Pending requested
-
Diff: 55 lines (+5/-5)3 files modifieddata/client-cert.whitelist (+2/-2)
data/client-selftest.whitelist (+2/-2)
debian/changelog (+1/-1)
Changed in checkbox: | |
status: | In Progress → Fix Committed |
Changed in checkbox: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Pending some investigation on whether PCMCIA and ExpressCard host controllers can be automatically detected, Ara's proposal sounds reasonable, although we'll again have the "absence of hardware means test failure" problem. It'd definitely be better to handle this through a requires: and some sort of device but I don't see anything in udev_resource we could use for this.
I'll mark this triaged and medium since we can start work on this now :)