Checkbox

suspend/wireless_before_suspend doesn't depend on wireless/wireless_connection

Bug #855371 reported by Brendan Donegan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
Medium
Unassigned
Checkbox 0.13 "first_p_release"

Bug Description

When networking/wireless_connection was moved to the new wireless.txt.in job file and renamed to wireless/wireless_connection (redundant? can't it just be called wireless/connection?) the dependencies of suspend/wireless_before_suspend weren't updated. This means that wireless_before_suspend can run before wireless/wireless_connection and *potentially* fail if the tester has not set up a wireless connection on their system yet. Making the dependency correct will make sure the tester does this and the wireless_before_suspend test will then only fail if the tester couldn't establish a connection anyway.

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

The requirements for wireless_before and after_suspend should also be updated to require a device.category == WIRELESS

Changed in checkbox:
milestone: none → 0.12.8
assignee: nobody → Brendan Donegan (brendan-donegan)
importance: Undecided → Medium
status: New → Incomplete
status: Incomplete → In Progress
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

It looks like the problem here could be deeper than it initially appears. Unless I'm doing something wrong it looks like wireless_before_suspend is running before wireless_connection anyway, regardless of the fixed dependency. I hope it's not being ignored.

Ara Pulido (ara)
Changed in checkbox:
status: In Progress → Triaged
assignee: Brendan Donegan (brendan-donegan) → nobody
Revision history for this message
Jeff Lane  (bladernr) wrote :

This is directly related to bug #861218

wireless_*_suspend are runnign before wireless connection because of two things:

A: checkbox doesn't currently allow dependencies to hop from suite to suite
B: wireless is after suspend alphabetically, so in theory, all the jobs in the wireless suite will be run after the jobs in the suspend suite.

Resolving 861218 should resolve this bug as well.

Revision history for this message
Jeff Lane  (bladernr) wrote :

bug #861218 is now resolved, fixing the dependencies for this should be all that's left to do.

Brendan Donegan (brendan-donegan)
Changed in checkbox:
assignee: nobody → Brendan Donegan (brendan-donegan)
status: Triaged → In Progress
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

We released 0.12.8 and this didn't go out, so retargeting for P

Changed in checkbox:
milestone: 0.12.8 → 0.13
status: In Progress → Triaged
assignee: Brendan Donegan (brendan-donegan) → nobody
Daniel Manrique (roadmr)
Changed in checkbox:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.