networks script dumps a traceback on Divide By Zero when ethtool doesn't report max speed properly
Bug #1257308 reported by
Jeff Lane
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Checkbox |
Fix Released
|
High
|
Jeff Lane | ||
Bug Description
Ran into a problem with the network script that caused a div by zero error due to ethtool not reporting max supported speed properly.
That was a firmware issue with the device, but this bug is about handling the divide by zero error more elegantly. The traceback is unnecessary here, we just need a failing exit and a message saying what the deal was
Related branches
lp://staging/~bladernr/checkbox/1257308
- Zygmunt Krynicki (community): Approve
- Jeff Lane : Needs Resubmitting
-
Diff: 41 lines (+16/-4)2 files modifiedcheckbox-old/debian/changelog (+3/-1)
checkbox-old/scripts/network (+13/-3)
Revision history for this message
| Jeff Lane (bladernr) wrote | #1 |
| Changed in checkbox: | |
| status: | New → Confirmed |
| assignee: | nobody → Jeff Lane (bladernr) |
| status: | Confirmed → Triaged |
| importance: | Undecided → High |
| status: | Triaged → In Progress |
Revision history for this message
| Jeff Lane (bladernr) wrote | #2 |
| Changed in checkbox: | |
| status: | In Progress → Fix Committed |
| Changed in checkbox: | |
| milestone: | none → 2013-dec-20 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
DEBUG:root:Shutting down interface:eth1
DEBUG:root:timeout 180 iperf -c 10.10.2.10 -n 1024M
Traceback (most recent call last):
File "/usr/share/
sys.
File "/usr/share/
return args.func(args)
File "/usr/share/
result = iperf_benchmark
File "/usr/share/
percent = scaled_throughput / int(self.
ZeroDivisionError: division by zero