the user execution controller should offer high score for root jobs when running as root
Bug #1254094 reported by
Zygmunt Krynicki
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Checkbox |
Fix Released
|
Medium
|
Daniel Manrique | ||
Bug Description
PlainBox has a concept of execution controllers that offer bids on who will execute a given job. The "user" execution controller is not offering any bids for jobs that need to run as root and such jobs go through either sudo, pkexec or the trusted launcher. This is inefficient when running as root (in the case of trusted launcher, very inefficient).
When the current user _is_ root then the user job execution controller should offer the best bid.
Related branches
lp://staging/~roadmr/checkbox/1254094-user-controller-bid
- Sylvain Pineau (community): Approve
-
Diff: 49 lines (+17/-2)2 files modifiedplainbox/plainbox/impl/ctrl.py (+4/-1)
plainbox/plainbox/impl/test_ctrl.py (+13/-1)
| tags: | added: mentoring |
| tags: | added: bitesize |
| Changed in checkbox: | |
| milestone: | none → plainbox-0.4b2 |
| Changed in checkbox: | |
| assignee: | nobody → Sylvain Pineau (sylvain-pineau) |
| status: | Triaged → In Progress |
Revision history for this message
| Sylvain Pineau (sylvain-pineau) wrote | #1 |
| Changed in checkbox: | |
| assignee: | Sylvain Pineau (sylvain-pineau) → Daniel Manrique (roadmr) |
| Changed in checkbox: | |
| status: | In Progress → Fix Committed |
| Changed in checkbox: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
My version did the same thing but in a separated (uneeded actually) class. We're both using os.getuid() == 0 and a score of 3.