network_device_info is too crude in categorising devices found by lspci
Bug #1091633 reported by
Brendan Donegan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox |
Fix Released
|
Medium
|
Sylvain Pineau |
Bug Description
network_
One possibility is to take advantage of the udev parser to find the network devices. This does a better job of categorising them already and is used by other parts of Checkbox
Related branches
lp://staging/~sylvain-pineau/checkbox/bug1091633
- Zygmunt Krynicki (community): Approve
- Brendan Donegan (community): Needs Information
-
Diff: 243 lines (+81/-36)4 files modifiedcheckbox/parsers/udevadm.py (+21/-0)
debian/changelog (+3/-0)
scripts/network_device_info (+56/-35)
scripts/udev_resource (+1/-1)
Changed in checkbox: | |
status: | In Progress → Fix Committed |
Changed in checkbox: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Indeed the udev parser will give better results. We could even get rid of querying the Networkmanager interface with dbus.
But will still have to use modinfo to get the driver version (not returned by udev).