keys/battery-info does not run due to failed requirement

Bug #1054410 reported by Brendan Donegan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
High
Brendan Donegan

Bug Description

The keys/battery-info test has started failing because of not fulfilling it's 'requires' line. It's a very strange failure though. The results file says:

Job requirements not met: 'd' 'm' 'i' '.' 'p' 'r' 'o' 'd' 'u' 'c' 't' ' ' 'i' 'n' ' ' '[' ''' 'N' 'o' 't' 'e' 'b' 'o' 'o' 'k' ''' ',' ''' 'L' 'a' 'p' 't' 'o' 'p' ''' ',' ''' 'P' 'o' 'r' 't' 'a' 'b' 'l' 'e' ''' ']'

The requires line seems to be getting split into different characters, of course causing the requires to fail.

Related branches

Revision history for this message
Daniel Manrique (roadmr) wrote :

The job definition is wrong, says "comand" instead of "command":

plugin: manual
name: keys/battery-info
requires: dmi.product in ['Notebook','Laptop','Portable']
comand: key_test -s '0xe071,0xef1:Battery Info'

It's the first thing I would change to see if it improves. Also note that key_test needs user:root.

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Heh, yep - discovered that at the airport yesterday (and it is in fact the source of the problem) but spent time procrastinating over trying to write a test which makes sure all job fields are valid. I think I'll just submit a simple fix for this and leave the test writing for a different merge.

Changed in checkbox:
status: New → Incomplete
status: Incomplete → In Progress
importance: Undecided → High
assignee: nobody → Brendan Donegan (brendan-donegan)
Zygmunt Krynicki (zyga)
Changed in checkbox:
status: In Progress → Fix Committed
Changed in checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.