keys/battery-info does not run due to failed requirement
Bug #1054410 reported by
Brendan Donegan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox |
Fix Released
|
High
|
Brendan Donegan |
Bug Description
The keys/battery-info test has started failing because of not fulfilling it's 'requires' line. It's a very strange failure though. The results file says:
Job requirements not met: 'd' 'm' 'i' '.' 'p' 'r' 'o' 'd' 'u' 'c' 't' ' ' 'i' 'n' ' ' '[' ''' 'N' 'o' 't' 'e' 'b' 'o' 'o' 'k' ''' ',' ''' 'L' 'a' 'p' 't' 'o' 'p' ''' ',' ''' 'P' 'o' 'r' 't' 'a' 'b' 'l' 'e' ''' ']'
The requires line seems to be getting split into different characters, of course causing the requires to fail.
Related branches
lp://staging/~brendan-donegan/checkbox/bug1054410
- Brendan Donegan (community): Needs Resubmitting
- Marc Tardif (community): Needs Information
- Zygmunt Krynicki (community): Approve
-
Diff: 99 lines (+22/-22)3 files modifieddebian/changelog (+2/-0)
jobs/keys.txt.in (+2/-1)
scripts/key_test (+18/-21)
lp://staging/~sylvain-pineau/checkbox/0.15
- Daniel Manrique (community): Approve
-
Diff: 1477 lines (+506/-529) (has conflicts)1 file modifieddebian/changelog (+506/-529)
Changed in checkbox: | |
status: | New → Incomplete |
status: | Incomplete → In Progress |
importance: | Undecided → High |
assignee: | nobody → Brendan Donegan (brendan-donegan) |
Changed in checkbox: | |
status: | In Progress → Fix Committed |
Changed in checkbox: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The job definition is wrong, says "comand" instead of "command":
plugin: manual ,'Laptop' ,'Portable' ] 0xef1:Battery Info'
name: keys/battery-info
requires: dmi.product in ['Notebook'
comand: key_test -s '0xe071,
It's the first thing I would change to see if it improves. Also note that key_test needs user:root.