Unable to open checkbox trunk

Bug #888435 reported by Javier Collado
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox Editor
Fix Released
High
Javier Collado

Bug Description

checkbox-editor fails when opening checkbox trunk: lp:checkbox

Related branches

Revision history for this message
Javier Collado (javier.collado) wrote :
Revision history for this message
Javier Collado (javier.collado) wrote :

The main problem here is that checkbox-editor assumes that test suites, that is, jobs that use the local plugin make use of the command field as follows:
cat <filename_pattern>

This is needed because checkbox-editor needs to know which file was used to get the test cases for a test suite to write changes back. However, checkbox trunk uses the command field not only to get a list of test cases from a file, but also to do some other things like:

- Generate test cases on the fly:
 cat <<'EOF' | run_templates -t -s 'udev_resource | filter_templates -w "category=DISK"'
 plugin: shell
 name: disk/benchmark_`ls /sys$path/block`
 requires: device.path == "$path" and package.name == 'linux'
 user: root
 command: hdparm -tT /dev/`ls /sys$path/block` | sed 's/:.*= */ = /' | grep -v "^$"
 description: This test runs hdparm timing tests as a benchmark for $path
 EOF

- Installing packages
dpkg -l | grep -iq 'ipmitool' || apt-get install -y ipmitool >/dev/null 2>&1

- Gather bootchar information
process_wait -u root bootchart collector ureadahead; \
 [ `ls /var/log/bootchart/*.tgz 2>/dev/null | wc -l` -lt 2 ] && reboot && sleep 100

While all this is completely fine, I don't think that this should be supported by checkbox-editor since it's beyond the use case it covers, so the best way to handle these commands is just try to display them without trying to extract any filename information from them.

Changed in checkbox-editor:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Javier Collado (javier.collado)
milestone: none → 0.10
Revision history for this message
Javier Collado (javier.collado) wrote :

Fix committed in lp:checkbox-editor (rev. 141)

Changed in checkbox-editor:
status: Triaged → Fix Committed
Revision history for this message
Javier Collado (javier.collado) wrote :

Fix released in checkbox-editor 0.10-0ubuntu1~rev141

Changed in checkbox-editor:
status: Fix Committed → Fix Released
Revision history for this message
Javier Collado (javier.collado) wrote :

Fixes were applied using an old checkbox trunk branch. After the update, some more fixes are required.

Changed in checkbox-editor:
status: Fix Released → In Progress
status: In Progress → Fix Released
Revision history for this message
Javier Collado (javier.collado) wrote :

Previous comment was a mistake.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.