When resuming a session, no option to pass or fail the last test being run
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox Converged |
Fix Released
|
High
|
Maciej Kisielewski |
Bug Description
Some tests may crash the system during testing. In those cases, we need to shutdown the device, restart it and resume testing with Checkbox.
When using checkbox-cli, when resuming, we can select if the previous test was passed, failed or we can re-run it if needed:
-------
$ checkbox-cli
=======
There is 1 incomplete session that might be resumed
Do you want to resume session 'pbox-wkv0h_u9'?
r => resume this session
n => next session
c => create new session
[rnc]: r
Previous session run tried to execute job: 2013.com.
What do you want to do with that job?
s => skip that job
p => mark it as passed and continue
f => mark it as failed and continue
r => run it again
[spfr]:
-------
This is very useful when running stress tests on a laptop for instance, because if for any reason the system freezes, we can assume the test failed, and when we restart the device and checkbox, we can mark it as failed.
When resuming a session with Checkbox converged, we have different options:
- Rerun the last job
- Continue
It's not very clear what "Continue" is supposed to do in the case where the last job crashed the system (and therefore Checkbox): does it skip the previous job? Does it mark it as passed?
It would be better to have feature parity with checkbox-cli.
Related branches
- Sylvain Pineau (community): Approve
- Pierre Equoy: Approve
-
Diff: 268 lines (+126/-27)6 files modifiedcheckbox-touch/checkbox-touch.qml (+9/-5)
checkbox-touch/components/CheckboxTouchApplication.qml (+2/-2)
checkbox-touch/components/ResumeSessionPage.qml (+30/-2)
checkbox-touch/py/checkbox_touch.py (+6/-2)
checkbox-touch/tests/autopilot/checkbox_touch/test_checkbox_touch.py (+79/-15)
plainbox/plainbox/impl/session/assistant.py (+0/-1)
Changed in checkbox-converged: | |
status: | New → In Progress |
assignee: | nobody → Maciej Kisielewski (kissiel) |
importance: | Undecided → High |
Changed in checkbox-converged: | |
status: | In Progress → Fix Committed |
Changed in checkbox-converged: | |
status: | Fix Committed → Fix Released |