avg load configuration should support 'auto' as procs option does
Bug #1578815 reported by
Felipe Reyes
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| nrpe (Juju Charms Collection) |
Fix Released
|
Medium
|
Felipe Reyes | ||
Bug Description
avg load uses a hardcoded value "-w 8,8,8 -c 15,15,15" that is not suitable for a lot of the modern servers with >=16 CPUs (as reported by lscpu), nor by small virtual machines (e.g. 4 cores).
It would be good if nrpe could be able to calculate a good value to use in the check, it's already done in the 'procs' configuration option.
@niedbalski suggested to use a "proc_count() * 0.7" for the warnings and "proc_count()" for the critical option, and I personally think it's a good formula.
Related branches
lp://staging/~freyes/charms/trusty/nrpe/lp1578815
- Review Queue (community): Needs Fixing (automated testing)
- Jorge Niedbalski (community): Needs Fixing
-
Diff: 55 lines (+17/-4)2 files modifiedconfig.yaml (+5/-2)
hooks/nrpe_helpers.py (+12/-2)
| Changed in nrpe (Juju Charms Collection): | |
| assignee: | nobody → Felipe Reyes (freyes) |
| Changed in nrpe (Juju Charms Collection): | |
| status: | New → In Progress |
| Changed in nrpe (Juju Charms Collection): | |
| importance: | Undecided → Medium |
| status: | In Progress → Fix Released |
To post a comment you must log in.
